Merge lp:~sergei.glushchenko/percona-pam-for-mysql/bug1166938 into lp:percona-pam-for-mysql

[Sergei Glushchenko]

workaround mysql workbench bug http://bugs.mysql.com/bug.php?id=72536

[Laurynas Biveinis (laurynas-biveinis)]

The comment on the line above now goes out of sync with the code. Say instead that we'd normally pass PASSWORD_USED_NO_MENTION here, but we are working around http://bugs.mysql.com/bug.php?id=72536

review: Needs Fixing

[Sergei Glushchenko (sergei.glushchenko)]

changed comment

[Laurynas Biveinis (laurynas-biveinis)]

review: Approve

=== modified file 'src/auth_pam_compat.c'
--- src/auth_pam_compat.c	2013-08-21 07:51:36 +0000
+++ src/auth_pam_compat.c	2014-05-14 13:32:17 +0000
@@ -95,8 +95,13 @@
     strncpy(resp->resp, (char *)pkt, pkt_len);
     resp->resp[pkt_len]= '\0';
 
-    /* we could only guess whether password was used or not */
-    data->info->password_used= PASSWORD_USED_NO_MENTION;
+    /**
+      we could only guess whether password was used or not
+      normally we would set PASSWORD_USED_NO_MENTION but
+      because of http://bugs.mysql.com/bug.php?id=72536
+      we set PASSWORD_USED_YES.
+    */
+    data->info->password_used= PASSWORD_USED_YES;
     ++(*num_talks);
   }