Merge lp:~sense/lernid/browserbuttons-sensitivity into lp:lernid

[Sense Egbert Hofstede]

[Sense Egbert Hofstede (sense)]

This branch makes the browser toolbar and the stop and reload buttons grey out (and in) when they should by listening to the 'hide', 'net-start', 'net-stop' and 'show' signals of self.browser.
Now you can't press Reload when a page is being loaded and you can only press Stop when something actually is being loaded.

If self.browser is being hidden the toolbar is made completely insensitive.

The browser toolbar and the stop button have been set to insensitive by default in the .ui files.

=== modified file 'bin/lernid'
--- bin/lernid	2009-12-23 16:33:59 +0000
+++ bin/lernid	2009-12-23 21:20:25 +0000
@@ -122,6 +122,12 @@
 
         # create browser widget        
         self.browser = gtkmozembed.MozEmbed()
+
+        # Connect the signals
+        self.browser.connect("hide", self.browser_hidden)
+        self.browser.connect("net-start", self.browser_loading)
+        self.browser.connect("net-stop", self.browser_loaded)
+        self.browser.connect("show", self.browser_shown)
         self.browser.connect("title", self.update_browser_title_combo)
         
         self.chat = gtkmozembed.MozEmbed()
@@ -382,7 +388,12 @@
     def browser_stop(self, widget):
         """Stop the current page loading in the browser view."""
 
+        refresh_button = self.builder.get_object("browser_refresh")
+        stop_button = self.builder.get_object("browser_stop")
+
+        stop_button.set_sensitive(False)
         self.browser.stop_load()
+        refresh_button.set_sensitive(True)
                         
     def send_notification(self, s):
         """Send a message to notify-osd."""
@@ -483,6 +494,49 @@
         if match == 0:
             self.browser.load_url(url)
             self.tabs.set_current_page(self.TAB_BROWSER)
+
+    def browser_hidden(self, widget):
+        """Make all buttons on the brower's toolbar insensitive"""
+
+        # We make the toolbar insensitive, and thereby its children as well
+        toolbar = self.builder.get_object("hbox1")
+        toolbar.set_sensitive(False)
+
+        print "hidden!\n"
+
+    def browser_loaded(self, widget):
+        """Mess with the stop and reload buttons
+            Stop -> insensitive
+            Reload -> sensitive"""
+
+        refresh_button = self.builder.get_object("browser_refresh")
+        stop_button = self.builder.get_object("browser_stop")
+
+        # Enable the refresh button and disnable the stop button now the
+        # webpage has been loaded
+        refresh_button.set_sensitive(True)
+        stop_button.set_sensitive(False)
+
+    def browser_loading(self, widget):
+        """Mess with the stop and reload buttons
+            Stop -> sensitive
+            Reload -> insensitive"""
+
+        refresh_button = self.builder.get_object("browser_refresh")
+        stop_button = self.builder.get_object("browser_stop")
+
+        # Disable the refresh button and enable the stop button when loading
+        # the webpage
+        refresh_button.set_sensitive(False)
+        stop_button.set_sensitive(True)
+
+    def browser_shown(self, widget):
+        """Make all buttons on the brower's toolbar sensitive"""
+
+        # We make the toolbar sensitive, and thereby restore its children
+        toolbar = self.builder.get_object("hbox1")
+        toolbar.set_sensitive(True)
+        print "shown!\n"
                                 
     def update_browser_title_combo(self, widget):
         """Update the browser title combo box with the new title."""
@@ -504,7 +558,7 @@
 
     def select_browser_title(self, widget):
         """Select an item from the browser combo box."""
-
+        
         self.browser.load_url(self.browser_liststore[self.browser_combo.get_active()][1])
 
     def about(self, widget, data=None):

=== modified file 'data/ui/LernidWindow.ui'
--- data/ui/LernidWindow.ui	2009-12-23 14:52:49 +0000
+++ data/ui/LernidWindow.ui	2009-12-23 21:20:25 +0000
@@ -215,6 +215,7 @@
                             <child>
                               <object class="GtkHBox" id="hbox1">
                                 <property name="visible">True</property>
+                                <property name="sensitive">False</property>
                                 <child>
                                   <object class="GtkButton" id="browser_refresh">
                                     <property name="visible">True</property>
@@ -238,6 +239,7 @@
                                 <child>
                                   <object class="GtkButton" id="browser_stop">
                                     <property name="visible">True</property>
+                                    <property name="sensitive">False</property>
                                     <property name="can_focus">True</property>
                                     <property name="receives_default">True</property>
                                     <property name="relief">none</property>