Merge lp:~sebastien.beau/openobject-server/openobject-server-debug-mode into lp:openobject-server

Proposed by Sébastien BEAU - http://www.akretion.com on 2012-07-09
Status: Rejected
Rejected by: Vo Minh Thu on 2012-10-08
Proposed branch: lp:~sebastien.beau/openobject-server/openobject-server-debug-mode
Merge into: lp:openobject-server
Diff against target: 100 lines (+39/-29)
2 files modified
openerp/osv/orm.py (+5/-2)
openerp/osv/osv.py (+34/-27)
To merge this branch: bzr merge lp:~sebastien.beau/openobject-server/openobject-server-debug-mode
Reviewer Review Type Date Requested Status
Vo Minh Thu 2012-07-11 Pending
OpenERP Core Team 2012-07-09 Pending
Review via email: mp+113996@code.launchpad.net

Description of the change

When using --debug mode error should be not re-catched in order to be a the appropriate line with pdb

To post a comment you must log in.
4238. By Fabien (Open ERP) on 2012-07-10

[IMP] American addresses + better form lyout

4239. By Fabien (Open ERP) on 2012-07-10

[merge] trunk-it

4240. By Launchpad Translations on behalf of openerp on 2012-07-11

Launchpad automatic translations update.

4241. By Quentin (OpenERP) <email address hidden> on 2012-07-11

[MERGE] akretion's branches

4242. By Fabien (Open ERP) on 2012-07-11

[IMP] module form view

4243. By van der Essen Frédéric (OpenERP) on 2012-07-11

[FIX] missing name in a view form broke the point of sale

4244. By Fabien (Open ERP) on 2012-07-13

[IMP] address format

4245. By Fabien (Open ERP) on 2012-07-14

[IMP] partner kanban, holidays, meeting

4246. By Fabien (Open ERP) on 2012-07-15

[IMP] kanban views for cstomers and suppliers in accounting

4247. By Quentin (OpenERP) <email address hidden> on 2012-07-16

[MERGE] settings: usablity, review of form views

4248. By Fabien (Open ERP) on 2012-07-16

[IMP] better form view: users, modules, preferences, wizards

4249. By Fabien (Open ERP) on 2012-07-16

[IMP] form view partners

4250. By Fabien (Open ERP) on 2012-07-16

[IMP] load translation wizard

4251. By Fabien (Open ERP) on 2012-07-16

[IMP] remove icons

4252. By Fabien (Open ERP) on 2012-07-17

[IMP] remove menu_tips code

4253. By Fabien (Open ERP) on 2012-07-17

[IMP] removed separator='vertical'

4254. By Raphael Collet (OpenERP) on 2012-07-17

[FIX] base/publisher_warranty: fix xml in view

4255. By Quentin (OpenERP) <email address hidden> on 2012-07-17

[MERGE] usability of user's preferences form view

4256. By Raphael Collet (OpenERP) on 2012-07-18

[MERGE] trunk-first_10_clicks_sale-rco

4257. By Launchpad Translations on behalf of openerp on 2012-07-19

Launchpad automatic translations update.

4258. By Quentin (OpenERP) <email address hidden> on 2012-07-19

[MERGE] sales/crm: usability, review of form views

4259. By Anto on 2012-07-19

[MERGE] improve top level menu items numerotation

4260. By Launchpad Translations on behalf of openerp on 2012-07-20

Launchpad automatic translations update.

4261. By Raphael Collet (OpenERP) on 2012-07-20

[MERGE] trunk-module-summary (add field 'summary' on modules)

4262. By Thibault Delavallée (OpenERP) on 2012-07-20

[MERGE] Merged OpenChatter part3: The Return of the Composer Reloaded Strikes Back. Server-side part of OpenChatter part 3, holding the new message composer. This revision adds an override of res.partner name_create method to support custom creation: <email address hidden> (name and email <email address hidden>), and Raoul <email address hidden> (name Raoul, email <email address hidden>).

4263. By Anto on 2012-07-20

[MERGE] fix Sale's top menu item sequence number

4264. By Olivier Dony (Odoo) on 2012-07-23

[MERGE] orm,fields: fields.char's argument now all optional (especially @size) + minor cleanup

The size limit on fields.char is entirely cosmetics,
as it makes no difference in performance or size for
PostgreSQL storage. The size only has to be specified
when the field needs to be size-constrained for
business reasons, like fixed-length references, EAN, etc.

4265. By Nicolas Vanhoren (OpenERP) on 2012-07-25

[IMP] cosmetic improvement in partner view

4266. By Raphael Collet (OpenERP) on 2012-07-25

[MERGE] trunk-first_10_clicks_crm-mdi (usability in crm)

4267. By Raphael Collet (OpenERP) on 2012-07-25

[MERGE] trunk-first_10_clicks_sale-rco (usability improvements)

4268. By Nicolas Vanhoren (OpenERP) on 2012-07-26

[IMP] minor customization to partners view, added default_focus

4269. By Launchpad Translations on behalf of openerp on 2012-07-27

Launchpad automatic translations update.

4270. By Launchpad Translations on behalf of openerp on 2012-07-28

Launchpad automatic translations update.

4271. By Launchpad Translations on behalf of openerp on 2012-07-29

Launchpad automatic translations update.

4272. By Launchpad Translations on behalf of openerp on 2012-07-31

Launchpad automatic translations update.

4273. By Quentin (OpenERP) <email address hidden> on 2012-07-31

[MERGE] clean search view branch

4274. By Launchpad Translations on behalf of openerp on 2012-08-01

Launchpad automatic translations update.

4275. By Vo Minh Thu on 2012-08-01

[MERGE] _rec_name is less permissive and has now a fallback.

4276. By Launchpad Translations on behalf of openerp on 2012-08-02

Launchpad automatic translations update.

4277. By Stephane Wirtel (OpenERP) on 2012-08-02

[MERGE] lp:~openerp-dev/openobject-server/trunk-addons-issues3-base-base_imp-pna

4278. By Stephane Wirtel (OpenERP) on 2012-08-02

[TYPO] Set the right category for the Point Of Sale

4279. By Stephane Wirtel (OpenERP) on 2012-08-02

[IMP] base: use the shortdesc in the search view of the modules

4280. By Stephane Wirtel (OpenERP) on 2012-08-02

[IMP] Use the button_immediate_install in the form view of the modules

4281. By Stephane Wirtel (OpenERP) on 2012-08-02

[FIX] Review the layout of the partners

4282. By Xavier (Open ERP) on 2012-08-02

[IMP] error-level log when non-stored function field without fnct_search is searched

holding off on blowing up an error just yet, but it might be a good idea in the end

4283. By Xavier (Open ERP) on 2012-08-02

[ADD] search view for res.groups to avoid searching on the unsearchable full_name from the default search view

4284. By Xavier (Open ERP) on 2012-08-02

[IMP] add more information when searching on a non-searchable field using debug logging

4285. By Launchpad Translations on behalf of openerp on 2012-08-03

Launchpad automatic translations update.

4286. By Stephane Wirtel (OpenERP) on 2012-08-03

[FIX] base: remove the uninstall button and improve the filter domain of the modules

4287. By Stephane Wirtel (OpenERP) on 2012-08-03

[MERGE]

4288. By Stephane Wirtel (OpenERP) on 2012-08-03

[REVERT] Revert the previous patch about the button_uninstall in the modules

4289. By Antony Lesuisse (OpenERP) on 2012-08-03

[MERGE] trunk-config-wizard indentation fixes by abo

4290. By Olivier Dony (Odoo) on 2012-08-03

[MERGE] name_get: support more field types and improve previous name_get changes

Introduces an improved name_get implementation,
supporting a few more fields type used as _rec_name
(such as many2one). The actual rendering of the
"display name" is delegated to the column class,
and computed based on the value returned by read()
for the column.

Funky @classmethod stuff was necessary to allow
column types to delegate to other types, such as
function types which can delegate to the real
type they emulate.

The display_name term was used because it is
being discussed for the new API to add a virtual
display_name column to all models, allowing
clients to read the name_get value along with
regular columns. It looks appropriate too.

Also fixes a few shortcomings of the latest
patches to name_get, such as supporting inherited
columns and avoiding a useless read() call with
only the id column.

4291. By Fabien (Open ERP) on 2012-08-04

[IMP] improved menu tips

4292. By Fabien (Open ERP) on 2012-08-04

[IMP] introducing new file type: html

4293. By Fabien (Open ERP) on 2012-08-04

[IMP] no content partners menutip

4294. By Fabien (Open ERP) on 2012-08-04

imp

4295. By Fabien (Open ERP) on 2012-08-04

[IMP] removing unused ir.actions.todo.category object

4296. By Fabien (Open ERP) on 2012-08-04

[IMP] remove unused code

4297. By Fabien (Open ERP) on 2012-08-05

[FIX] removed ir.actions.todos category_id

4298. By Xavier (Open ERP) on 2012-08-06

[IMP] code style improvements

* Remove unused variables
* Simplify dict.get call in conditionals (default is None)
* Simplify dict.update calls (use kwargs)
* Merge dict.copy() with dict.update() as dict()
* Use isinstance instead of type() equality tests
* Simplify deeply nested code: merge conditionals and remove useless
  conditional, use dict.iteritems()
* Log traceback in exception handler logging

4299. By Antony Lesuisse (OpenERP) on 2012-08-06

[REM] fields float integer useless warning, required can be used to color the field in blue on form view

4300. By Fabien (Open ERP) on 2012-08-06

[IMP] cleaning views, reduced summary and module name fields (to avoid crap in apps.openerp.com)

4301. By Fabien (Open ERP) on 2012-08-06

[MERGE] improved placeholders

4302. By Stephane Wirtel (OpenERP) on 2012-08-07

[MERGE] lp:~openerp-dev/openobject-server/trunk-addons-issues3-base

4303. By Thibault Delavallée (OpenERP) on 2012-08-07

[MERGE] MyNotChatterTask: image resize.

This revision adds standard image field names and sizes (image: 1024x1024; image_medium: 180x180; image_small: 50x50, the last two being function fields). This server-side branch holds the tools functions for image resizing (with aspect ratio preserved), and update for res.partner and res.users.

4304. By Stephane Wirtel (OpenERP) on 2012-08-07

[IMP] base: Add a wizard to install a list of modules

4305. By Stephane Wirtel (OpenERP) on 2012-08-07

[FIX] base: Allow the quick create for a partner

4306. By Olivier Dony (Odoo) on 2012-08-07

[IMP] tools.reference_re: support matching model name as well

4307. By Fabien (Open ERP) on 2012-08-07

[IMP] internal notes as first tab

4308. By Fabien (Open ERP) on 2012-08-07

[IMP] contact in partners

4309. By Stephane Wirtel (OpenERP) on 2012-08-08

[FIX] module: Use the button_immediate_XYZ of the upgrade and uninstall buttons in the form view

4310. By Vo Minh Thu on 2012-08-08

[IMP] test addons: pushed the Tests menu to the far right (probably into the MOAR button).

4311. By Olivier Dony (Odoo) on 2012-08-08

[MERGE] db: module auto-install should work recursively during db bootstrap too

4312. By Antony Lesuisse (OpenERP) on 2012-08-08

[IMP] user preference is regular wizard

4313. By Antony Lesuisse (OpenERP) on 2012-08-08

[IMP] user preference is regular wizard, change password in a popup

4314. By Stephane Wirtel (OpenERP) on 2012-08-09

[MERGE] lp:~openerp-dev/openobject-server/trunk-res_bank_remove_footer-mdi

4315. By Quentin (OpenERP) <email address hidden> on 2012-08-09

[REV] reverted previous commit (4314) that removes footer field on res.partner.bank, because specs changed

4316. By Fabien Meghazi (OpenERP) on 2012-08-09

[FIX] res.users small and medium images has no default value

4317. By Fabien Meghazi (OpenERP) on 2012-08-09

[FIX] res.partners small and medium images has no default value

4318. By Launchpad Translations on behalf of openerp on 2012-08-10

Launchpad automatic translations update.

4319. By Vo Minh Thu on 2012-08-10

[MERGE] impex tests: added test module to unittest import/export.

4320. By Anto on 2012-08-10

[MERGE] add options='{"no_open": true} on some fields
with this modification, users won't be able to open countries or languages form views anymore, which didn't really make sense

4321. By Launchpad Translations on behalf of openerp on 2012-08-11

Launchpad automatic translations update.

4322. By Antony Lesuisse (OpenERP) on 2012-08-11

[IMP] act_window allow target inlineview

4323. By Fabien (Open ERP) on 2012-08-13

[MERGE] demo data

4324. By Fabien (Open ERP) on 2012-08-13

[IMP] removing structure

4325. By Fabien (Open ERP) on 2012-08-13

[IMP] uncommit hyearchical categories

4326. By Christophe Simonis (OpenERP) on 2012-08-13

[IMP] this is version 7

4327. By Christophe Simonis (OpenERP) on 2012-08-13

[IMP] add cursor() contextmanager on registry

4328. By Thibault Delavallée (OpenERP) on 2012-08-14

[MERGE] 'My Second Not-Chatter Merge of the Day': add a deprecated attribute on fields.

This revision adds a string 'deprecated' attribute on fields. If not False, the ORM makes a warning when attempting to read the read, or write on it.
Use: 'my_field': fields.char('Old field', size=64, deprecated="This field will be removed with version 42 of OpenERP. Please yse 'my_new_field' instead.")

4329. By Vo Minh Thu on 2012-08-14

[MERGE] merged view changes: the `type` is now a functional field derived from the arch.

4330. By Fabien (Open ERP) on 2012-08-14

[IMP] removing structure in partner tags

4331. By Fabien (Open ERP) on 2012-08-14

[IMP] removed categories in tags , fix

4332. By Fabien (Open ERP) on 2012-08-14

merge

4333. By Fabien (Open ERP) on 2012-08-14

fix

4334. By Antony Lesuisse (OpenERP) on 2012-08-15

[MERGE] res.users inherits res.partner

4335. By Antony Lesuisse (OpenERP) on 2012-08-15

[IMP] res_users check,login,authenticate cleanup

4336. By Thibault Delavallée (OpenERP) on 2012-08-16

[MERGE] Merged OpenChatter-3-5 followers refactoring. This server-side branch holds a small refactoring in many2many fields: the query has been taken in a method to be more easily overiden. Please note that this commit is likely to be trashed when merging trunk-mail-review.

4337. By Vo Minh Thu on 2012-08-16

[IMP] html_sanitize: remove dependency on pyquery.

Relying on pyquery is unnecessary (using etree alone is enough). This patch
reimplements the html_sanitize() function without pyquery. The new
implementation still goes through the provided test suite with success.

4338. By Christophe Simonis (OpenERP) on 2012-08-16

[IMP] handle menuitems with "server" and "client" type + ensure menu has a name

4339. By Christophe Simonis (OpenERP) on 2012-08-16

[FIX] res.users: context_get: read fields as root

4340. By Fabien Meghazi (OpenERP) on 2012-08-16

[REM] Kanban autoheight is now the default behavior in non grouped mode

4341. By Antony Lesuisse (OpenERP) on 2012-08-16

[FIX] preferences buttons

4342. By Quentin (OpenERP) <email address hidden> on 2012-08-17

[MERGE] merged branch with pictures of contacts (demo data)

4343. By Quentin (OpenERP) <email address hidden> on 2012-08-17

[FIX] base: removed address of main company. Having an address there is problematic because it automatically installs a COA

4344. By Quentin (OpenERP) <email address hidden> on 2012-08-17

[FIX] base: the label of vat field now displays 'TIN' instead of 'TVA'. A US term consistent with the default value of the language used.

4345. By Antony Lesuisse (OpenERP) on 2012-08-19

[MERGE] diagram view label

4346. By Quentin (OpenERP) <email address hidden> on 2012-08-20

[FIX] base: restored translations for label 'VAT' changed into 'TIN' in revision 4344

4347. By Nicolas Vanhoren (OpenERP) on 2012-08-21

[IMP] changed partners view to work correctly with linkedin module (still need improvements in the web client to support preview_image)

4348. By Nicolas Vanhoren (OpenERP) on 2012-08-21

[IMP] Even more improved images in partners

4349. By Nicolas Vanhoren (OpenERP) on 2012-08-22

[FIX] typo

4350. By Christophe Simonis (OpenERP) on 2012-08-22

[IMP] log exceptions as exceptions

4351. By Christophe Simonis (OpenERP) on 2012-08-22

[IMP] yaml import: log as TEST only for test files

4352. By Christophe Simonis (OpenERP) on 2012-08-22

[FIX] sequence testing

4353. By Christophe Simonis (OpenERP) on 2012-08-22

[IMP] remove unwanted log in test

4354. By Christophe Simonis (OpenERP) on 2012-08-22

[IMP] tools.misc.mute_logger can now be used as decorator

4355. By Christophe Simonis (OpenERP) on 2012-08-22

[FIX] remove loggging for test "test_out_of_range" of "test_impex" module

4356. By Vo Minh Thu on 2012-08-22

[FIX] tests: allow running the tests when installing a database created by XML-RPC.

4357. By Stephane Wirtel (OpenERP) on 2012-08-22

[FIX] base: remove the sequence field in a view

4358. By Anto on 2012-08-22

[MERGE] improve modules' descriptions
also properly render descriptions from RST into HTML

4359. By Vo Minh Thu on 2012-08-23

[FIX] setup.py: added docutils dependency introduced at revision 4341.3.1.

4360. By Olivier Dony (Odoo) on 2012-08-23

[MERGE] convert: fix previous partial patch for removing redundant @type for <menuitem>

4361. By Anto on 2012-08-23

[MERGE] minor improvements on @noupdate
also fix some indentation

4362. By Vo Minh Thu on 2012-08-23

[FIX] uninstall: pass IDs instead of names to _module_data_uninstall().

4363. By Vo Minh Thu on 2012-08-24

[FIX] uninstall: delete all given ir_model_relation/ir_model_constraint (still making sure the protected resource is not deleted if still referenced elsewhere).

4364. By Anto on 2012-08-24

[MERGE] module: improve modules' descriptions rendering and keep it translatable

4365. By Vo Minh Thu on 2012-08-24

[FIX] custom models: avoid calling twice __init__, use a correct _rec_name (calling twice __init__ caused the _rec_name to be `name` which does not exist on a custom model, and caused the assert on the _rec_name to fail.

4366. By Fabien (Open ERP) on 2012-08-27

[IMP] correct address format

4367. By Fabien (Open ERP) on 2012-08-27

merge

4368. By Launchpad Translations on behalf of openerp on 2012-08-28

Launchpad automatic translations update.

4369. By Stephane Wirtel (OpenERP) on 2012-08-28

[MERGE] Remove the pychart library, use the online version via pypi or the package manager

4370. By Fabien Meghazi (OpenERP) on 2012-08-29

[IMP] Use 'open' action in kanban views

4371. By Xavier (Open ERP) on 2012-08-30

[FIX] lxml 3.0a2 has been deployed to pypi for some reason, pin to lxml < 3 for now

4372. By Quentin (OpenERP) <email address hidden> on 2012-08-31

[MERGE] merged the branch with enhancements of ir.translation. Those changes are needed for base_gengo module

4373. By Minh Tran (OpenERP) on 2012-08-31

Random generation of avatar

4374. By Minh Tran (OpenERP) on 2012-08-31

fix merge crap

4375. By Minh Tran (OpenERP) on 2012-08-31

fix old avatar code

4376. By Stephane Wirtel (OpenERP) on 2012-08-31

[REF] Replace the user id 1 by openerp.SUPERUSER_ID

4377. By Stephane Wirtel (OpenERP) on 2012-08-31

[MERGE] base: fix the read method with the ids argument

4378. By Stephane Wirtel (OpenERP) on 2012-08-31

[FIX] base: Remove the default value for the image

4379. By Stephane Wirtel (OpenERP) on 2012-09-01

[ADD] Add a script to install all the modules in a trunk database with the tests

4380. By Fabien (Open ERP) on 2012-09-02

[IMP] usability partner logo as avatar class

4381. By Fabien (Open ERP) on 2012-09-03

[FIX] all image stuff on groups, users, partners

4382. By Vo Minh Thu on 2012-09-03

[FIX] yaml_import: really raise YamlImportExceptions.

4383. By Vo Minh Thu on 2012-09-03

[FIX] ad_paths: makes sure the server addons path is absolute (needed when using cProfile).

4384. By Vo Minh Thu on 2012-09-03

[FIX] test_ir_sequence: reduce the number of call to next() (to reduce test time).

4385. By Stephane Wirtel (OpenERP) on 2012-09-04

[FIX] Reset the right python environment

4386. By Olivier Dony (Odoo) on 2012-09-04

[MERGE] file_open: give precedence to directory before zip, courtesy of Florent Xicluna

4387. By Stephane Wirtel (OpenERP) on 2012-09-04

[FIX] amount_to_text: avoid to have a none in the concat

4388. By Stephane Wirtel (OpenERP) on 2012-09-04

[IMP] disable the document_ftp in the run_all_with_test script

4389. By Raphael Collet (OpenERP) on 2012-09-04

[MERGE] trunk-editable_list (add groups on views to disable some inherited views when composing a view)

4390. By Fabien Meghazi (OpenERP) on 2012-09-04

[ADD] ir.translation#translate_fields

4391. By Launchpad Translations on behalf of openerp on 2012-09-05

Launchpad automatic translations update.

4392. By Nicolas Vanhoren (OpenERP) on 2012-09-05

[IMP] modified all <li> to adjust to new default style

4393. By Raphael Collet (OpenERP) on 2012-09-05

[MERGE] trunk-access-ui-jam (in fields_view_get, add attributes in top element when user cannot create/edit/delete)

4394. By vta <email address hidden> on 2012-09-05

[FIX] Fixed width in div.address_format's spans.

4395. By Nicolas Vanhoren (OpenERP) on 2012-09-05

[REVERT] 4394, because Thu is stupid

4396. By Nicolas Vanhoren (OpenERP) on 2012-09-05

[IMP] removed dependency to pyquery

4397. By Fabien (Open ERP) on 2012-09-05

[IMP] correct logo of company for base.main_company

4398. By Olivier Dony (Odoo) on 2012-09-06

[MERGE] server part of mail/chatter complete review/refactoring

Attempt at cleaning up and simplifying the mail-related
APIs and code, including mail.thread, mail.message,
`needaction`, open-chatter and the related components.
The server part specifically deals with simplifying
the ir.needaction mechanism, as well as adding
support for callable `domain` properties on
one2many fields, and improving the ways to
create new partners based on a simple name
or email (name_create et al).
This branch has an addons part as well, taking care of
cleaning up the mail-related modules.

4399. By Fabien (Open ERP) on 2012-09-06

[IMP] folded columns in read_group

4400. By Fabien (Open ERP) on 2012-09-06

fix

4401. By Launchpad Translations on behalf of openerp on 2012-09-07

Launchpad automatic translations update.

4402. By Fabien (Open ERP) on 2012-09-07

[MERGE] currency

4403. By Olivier Dony (Odoo) on 2012-09-07

[FIX] debian/control: missing dependency on docutils

Was added to setup.py but not in deb packaging.

4404. By Launchpad Translations on behalf of openerp on 2012-09-08

Launchpad automatic translations update.

4405. By Xavier (Open ERP) on 2012-09-06

[ADD] test for retarded behavior when importing o2m _rec_name

4406. By Thibault Delavallée (OpenERP) on 2012-09-10

[MERGE] Small image cleaning
- moved the avatar colorize part of the image code to tools/image.py, where it should have been placed at revs 4373-4375
- added the option for not up-sizing image smaller than the resize limits
- default image_small size is now 64x64 px
- default image_medium size is now 128x128 px
- overall code and comments cleaning

4407. By Olivier Dony (Odoo) on 2012-09-10

[MERGE] Simplified report footer configuration per company - comes with corresponding addons branch

4408. By Launchpad Translations on behalf of openerp on 2012-09-11

Launchpad automatic translations update.

4409. By Stephane Wirtel (OpenERP) on 2012-09-11

[MERGE] report & netrpc protocol: Use the cPickle 2.0 protocol and clean the code of report

4410. By Fabien (Open ERP) on 2012-09-11

[IMP] clean address formatting per countries

4411. By Fabien (Open ERP) on 2012-09-11

[IMP] Address Format in Reports

4412. By Stephane Wirtel (OpenERP) on 2012-09-11

[MERGE] base: raise an exception if the format of the bank account is wrong

4413. By Stephane Wirtel (OpenERP) on 2012-09-11

[MERGE] raise an exception if it can't evaluate a string

4414. By Stephane Wirtel (OpenERP) on 2012-09-11

[MERGE] base: fix some address formats and some English

4415. By Stephane Wirtel (OpenERP) on 2012-09-11

[MERGE] base: fix typo of some languages

4416. By Stephane Wirtel (OpenERP) on 2012-09-11

[MERGE] Remove unused res.payterm

4417. By Fabien (Open ERP) on 2012-09-11

[IMP] quick create partners usability

4418. By Fabien (Open ERP) on 2012-09-11

[MERGE]

4419. By Launchpad Translations on behalf of openerp on 2012-09-12

Launchpad automatic translations update.

4420. By Stephane Wirtel (OpenERP) on 2012-09-12

[FIX] openerp.tools.misc.file_open: Very little fix to display coherent error message when file not found occurs.

4421. By Stephane Wirtel (OpenERP) on 2012-09-12

[MERGE] set the write_uid, write_date for the create

4422. By Stephane Wirtel (OpenERP) on 2012-09-12

[MERGE] improve the tools.misc.scan_languages function

4423. By Stephane Wirtel (OpenERP) on 2012-09-12

[MERGE] use the postgres db instead of template1 for the creation of a database

4424. By Stephane Wirtel (OpenERP) on 2012-09-12

[IMP] openerp.service.web_services.db: Use a contextmanager for the backup/restore functions.
Ported from lp:~openerp-dev/openobject-server/trunk-dump_and_restore_improvements-xmo

4425. By Fabien (Open ERP) on 2012-09-12

[IMP] partner views

4426. By Antony Lesuisse (OpenERP) on 2012-09-12

[MERGE] fields_view dont load translations if lang is not defined

4427. By Fabien (Open ERP) on 2012-09-12

[FIX] quick create of partners, better layout

4428. By Thibault Delavallée (OpenERP) on 2012-09-13

[MERGE] [FIX] Fixed image sharpening in tools; this requires an image converted into RGB.

4429. By Vo Minh Thu on 2012-09-13

[MERGE] fix: renamed thousand_sep to thousands_sep in test_impex, removed rml_footer1 and rml_footer2 from data as the fields were removed.

4430. By Raphael Collet (OpenERP) on 2012-09-13

[MERGE] trunk-res_rml_footer-rco (improve onchange on res.company form)

4431. By Anto on 2012-09-13

[FIX] fields_get check_access_right

4432. By Fabien (Open ERP) on 2012-09-13

[IMP] address format according to country of user on partners

4433. By Fabien (Open ERP) on 2012-09-13

[IMP] address format according to user's country

4434. By Fabien (Open ERP) on 2012-09-13

[IMP] rename coutnries

4435. By Fabien (Open ERP) on 2012-09-13

fix

4436. By Fabien (Open ERP) on 2012-09-13

[IMP] better layout for BE address

4437. By Vo Minh Thu on 2012-09-14

[IMP] report: added TTF font path (used in e.g. Arch Linux).

4438. By Fabien (Open ERP) on 2012-09-16

[IMP] cleaned ir.actions.todo to launch newly installed application

4439. By Fabien (Open ERP) on 2012-09-16

[FIX] open menu

4440. By Fabien (Open ERP) on 2012-09-16

[IMP] better algo for image thumbnails

4441. By Olivier Dony (Odoo) on 2012-09-18

[REF] allow to intercept the signals sent to workflows (through buttons) in objects. This is done by adding a function named _workflow_signal() in orm that can be inherited in dedicated objects. Courtesy from Olivier Dony

4442. By Fabien (Open ERP) on 2012-09-19

[IMP] removing partner manager from sale as it will be in home

4443. By Launchpad Translations on behalf of openerp on 2012-09-20

Launchpad automatic translations update.

4444. By Fabien (Open ERP) on 2012-09-20

[MERGE] supplier demo data

4445. By Olivier Laurent (Open ERP) on 2012-09-20

[FIX] fixed message format (wrong number of arguments)

4446. By Launchpad Translations on behalf of openerp on 2012-09-21

Launchpad automatic translations update.

4447. By Antony Lesuisse (OpenERP) on 2012-09-22

[MERGE] wsgi overhaul, native arbiter, service and startup cleanups
add a generic wsgi entry point openrp-wsgi.py that should work for all wsgi servers (gunicorn, uwsgi, ...)
add a simple native multiprocessing arbiter option --workers=num
add limits options (cpu, memory, time) for the native aribter --limit-*

4448. By Antony Lesuisse (OpenERP) on 2012-09-24

[FIX] wsgi wrapper

4449. By Olivier Dony (Odoo) on 2012-09-24

[IMP] ir.ui.view: discard custom views before updating view arch

- as the custom views are still in place when validating the new arch, they would
hide the new arch and prevent proper validation (if custom views are set for uid 1)
- conversely, if the RNG validation has changed, the old view customizations may not
pass the updated validation rules, and cause spurious validation errors

4450. By Antony Lesuisse (OpenERP) on 2012-09-24

[FIX] gunicorn wsgi wrapper instructions

4451. By Antony Lesuisse (OpenERP) on 2012-09-24

[FIX] restore poxy-mode command line option to prevent ip address impersonation

4452. By Quentin (OpenERP) <email address hidden> on 2012-09-24

[MERGE] demo data improved (new rate for USD)

4453. By Antony Lesuisse (OpenERP) on 2012-09-25

[FIX] fcntl not available on windows

4454. By Launchpad Translations on behalf of openerp on 2012-09-25

Launchpad automatic translations update.

4455. By Fabien (Open ERP) on 2012-09-26

[FIX] useability partner tab visible

4456. By Quentin (OpenERP) <email address hidden> on 2012-09-26

[MERGE] small usability improvement in res.partner form view

4457. By Fabien (Open ERP) on 2012-09-26

[IMP] no certificate

4458. By Olivier Dony (Odoo) on 2012-09-26

[MERGE] fields: cleanup field_to_dict + make @deprecated available in fields_get()

Renamed the m2m extra info keys, as their names
were quite confusing (third_table?), + removed
the "func_obj" key for function fields, as
it was a duplicate of the "relation" kay that
is already present for all relationship fields.
These renames should not break anything, as this
info should only be used for debug, but they still
constitute an API backwards-incompatible change.

4459. By Quentin (OpenERP) <email address hidden> on 2012-09-27

[FIX] base: USD currency symbol should be displayed before the amount

4460. By Fabien (Open ERP) on 2012-09-27

[MERGE] Access Rights Groups use same name than menu

4461. By Rucha (Open ERP) on 2012-09-28

[IMP]: base: * Changed photo of contact so it should look like avtar,
* Added new logo for camptocamp and added new company(Vauxoo)

4462. By Fabien (Open ERP) on 2012-09-28

[MERGE] misc fixes trunk-fp

4463. By Fabien (Open ERP) on 2012-09-28

[FIX] user preferences

4464. By Anto on 2012-09-28

[MERGE] trunk-fix-mail-mail-rules-tde: OpenChatter 'Rule Yur Daddy' Branch

Fixes some of access rights issues. This server branch features :
- update of res.users model, where the feature allowing to write on its own user on WRITABLE_FIELDS is duplicated for reading. This allows for users not having read access on res.partner to read some of their data.

4465. By Fabien (Open ERP) on 2012-09-29

[MERGE] active of ACLs, courtesy of akretion

4466. By Olivier Dony (Odoo) on 2012-10-01

[FIX] base: ridiculous typo in Nhomar's first name, sorry about that

4467. By Olivier Dony (Odoo) on 2012-10-02

[IMP] ir.actions: rename ir.actions.url (model) to ir.actions.act_url

All other action types use model name for type,
and there are pieces of code assuming this
(and no other way to reverse the model from
the ir.actions.actions either way).

Related branches will land at the same time
in addons and web.

4468. By Fabien Meghazi (OpenERP) on 2012-10-02

[IMP] Do not start cron master thread if max_cron_threads == 0

4469. By Xavier (Open ERP) on 2012-10-02

[IMP] use generic header template in form views

also small reindent in view with fucked-up indentation

4470. By Olivier Dony (Odoo) on 2012-10-03

[REV] Undo header template extraction

4471. By Launchpad Translations on behalf of openerp on 2012-10-04

Launchpad automatic translations update.

4472. By Olivier Dony (Odoo) on 2012-10-04

[MERGE] Unify PO extraction system between server/addons and web + minor cleanup

4473. By Christophe Simonis (OpenERP) on 2012-10-04

[MERGE] orm: handle correctly char size change

4474. By Raphael Collet (OpenERP) on 2012-10-05

[FIX] ir: small fix to handle missing models when upgrading

4475. By Quentin (OpenERP) <email address hidden> on 2012-10-05

[MERGE] improvements/fixes of yaml_import for a more realistic creation of record (as if it was done by a form view)
 * Upon creation of records in yaml, the view to use for the one2many fields should be the one define in-line in the record form view (if any)
 * Now raises an error if an onchange call returns a field that is not in the view (because computing something that is of no use is probably not expected: the onchange OR the view should be fixed/improved)
 * Improve performances by reducing the number of fields_view_get() and fields_get() call
 * code refactoring

Vo Minh Thu (thu) wrote :

At first I thought it was a good idea to let the exceptions go unhandled (re-raise them) until the final try/catch befor the RPC layer, so that pdb.post_mortem() is called.

But I don't think it is actually a good idea.

There are already cases where the exceptions go until the pdb.post_mortem() call: all the non-OpenERP-specific exceptions (the ones defined in openerp.exceptions, and the deprecated except_osv and except_orm) will hit the pdb.post_mortem().

Whenever a try/catch occurs and raises an OpenERP-specific exception, this means the problem is handled by OpenERP, should be presented to the user in a specific way, and the user can possibly take action to solve the problem.

All other kind of exceptions can be regarded as bugs in the system and lead to pdb be entered.

Now the problem you might face (and if I understand correctly the reason you proposed this patch) is that some problems might be mistakenly turned into OpenERP-specific exceptions. If this is the case, the solution is to fix the code (so it catches more precisely the underlying problem and (re-)raises an OpenERP-specific exception only if it is relevant).

(I will put the MP to `rejected`; feel free to put it back to `need review` if needed.)

Alexis de Lattre (alexis-via) wrote :

This merge proposal is a life saver for debugging ! I have used it today again and I could not find the problem without it ! :)

Note, proposed for merge on OCA/OCB on Github here https://github.com/OCA/OCB/pull/35

Unmerged revisions

4888. By Sébastien BEAU - http://www.akretion.com on 2013-03-11

[FIX] fix debug mode due to change done is main branch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/osv/orm.py'
2--- openerp/osv/orm.py 2012-07-02 16:20:22 +0000
3+++ openerp/osv/orm.py 2012-07-09 16:20:39 +0000
4@@ -2154,8 +2154,11 @@
5 view = getattr(self, '_get_default_%s_view' % view_type)(
6 cr, user, context)
7 except AttributeError:
8- # what happens here, graph case?
9- raise except_orm(_('Invalid Architecture!'), _("There is no view of type '%s' defined for the structure!") % view_type)
10+ if config['debug_mode']:
11+ raise
12+ else:
13+ # what happens here, graph case?
14+ raise except_orm(_('Invalid Architecture!'), _("There is no view of type '%s' defined for the structure!") % view_type)
15
16 result.update(
17 arch=view,
18
19=== modified file 'openerp/osv/osv.py'
20--- openerp/osv/osv.py 2012-01-24 12:42:52 +0000
21+++ openerp/osv/osv.py 2012-07-09 16:20:39 +0000
22@@ -33,6 +33,7 @@
23 from openerp.tools.translate import translate
24 from openerp.osv.orm import MetaModel, Model, TransientModel, AbstractModel
25 import openerp.exceptions
26+from openerp.tools.config import config
27
28 _logger = logging.getLogger(__name__)
29
30@@ -120,37 +121,43 @@
31 raise except_osv('Database not ready', 'Currently, this database is not fully loaded and can not be used.')
32 return f(self, dbname, *args, **kwargs)
33 except orm.except_orm, inst:
34- raise except_osv(inst.name, inst.value)
35+ if config['debug_mode']:
36+ raise
37+ else:
38+ raise except_osv(inst.name, inst.value)
39 except except_osv:
40 raise
41 except IntegrityError, inst:
42- osv_pool = pooler.get_pool(dbname)
43- for key in osv_pool._sql_error.keys():
44- if key in inst[0]:
45- netsvc.abort_response(1, _('Constraint Error'), 'warning',
46- tr(osv_pool._sql_error[key], 'sql_constraint') or inst[0])
47- if inst.pgcode in (errorcodes.NOT_NULL_VIOLATION, errorcodes.FOREIGN_KEY_VIOLATION, errorcodes.RESTRICT_VIOLATION):
48- msg = _('The operation cannot be completed, probably due to the following:\n- deletion: you may be trying to delete a record while other records still reference it\n- creation/update: a mandatory field is not correctly set')
49- _logger.debug("IntegrityError", exc_info=True)
50- try:
51- errortxt = inst.pgerror.replace('«','"').replace('»','"')
52- if '"public".' in errortxt:
53- context = errortxt.split('"public".')[1]
54- model_name = table = context.split('"')[1]
55- else:
56- last_quote_end = errortxt.rfind('"')
57- last_quote_begin = errortxt.rfind('"', 0, last_quote_end)
58- model_name = table = errortxt[last_quote_begin+1:last_quote_end].strip()
59- model = table.replace("_",".")
60- model_obj = osv_pool.get(model)
61- if model_obj:
62- model_name = model_obj._description or model_obj._name
63- msg += _('\n\n[object with reference: %s - %s]') % (model_name, model)
64- except Exception:
65- pass
66- netsvc.abort_response(1, _('Integrity Error'), 'warning', msg)
67+ if config['debug_mode']:
68+ raise
69 else:
70- netsvc.abort_response(1, _('Integrity Error'), 'warning', inst[0])
71+ osv_pool = pooler.get_pool(dbname)
72+ for key in osv_pool._sql_error.keys():
73+ if key in inst[0]:
74+ netsvc.abort_response(1, _('Constraint Error'), 'warning',
75+ tr(osv_pool._sql_error[key], 'sql_constraint') or inst[0])
76+ if inst.pgcode in (errorcodes.NOT_NULL_VIOLATION, errorcodes.FOREIGN_KEY_VIOLATION, errorcodes.RESTRICT_VIOLATION):
77+ msg = _('The operation cannot be completed, probably due to the following:\n- deletion: you may be trying to delete a record while other records still reference it\n- creation/update: a mandatory field is not correctly set')
78+ _logger.debug("IntegrityError", exc_info=True)
79+ try:
80+ errortxt = inst.pgerror.replace('«','"').replace('»','"')
81+ if '"public".' in errortxt:
82+ context = errortxt.split('"public".')[1]
83+ model_name = table = context.split('"')[1]
84+ else:
85+ last_quote_end = errortxt.rfind('"')
86+ last_quote_begin = errortxt.rfind('"', 0, last_quote_end)
87+ model_name = table = errortxt[last_quote_begin+1:last_quote_end].strip()
88+ model = table.replace("_",".")
89+ model_obj = osv_pool.get(model)
90+ if model_obj:
91+ model_name = model_obj._description or model_obj._name
92+ msg += _('\n\n[object with reference: %s - %s]') % (model_name, model)
93+ except Exception:
94+ pass
95+ netsvc.abort_response(1, _('Integrity Error'), 'warning', msg)
96+ else:
97+ netsvc.abort_response(1, _('Integrity Error'), 'warning', inst[0])
98 except Exception:
99 _logger.exception("Uncaught exception")
100 raise