Code review comment for lp:~sebastien.beau/openerp-product-attributes/openerp-product-attributes-product-dimension

Marc Cassuto (SFL) (mcassuto) wrote :

Hi Guewen, Sébastien,

I wonder if we should not reuse existing code :
https://code.launchpad.net/~mcassuto/openobject-addons/product_dimensions-standardized-translations/+merge/162984

This code also deal with the volume issue...

My 2 cents,
Marc

==
Marc Cassuto, Ing. MBA Itil

SAVOIR-FAIRE LINUX
Consultant solutions ERP
T: 514-276-5468 #180

----- Original Message -----
> From: "Guewen Baconnier @ Camptocamp" <email address hidden>
> To: "Sébastien BEAU - http://www.akretion.com" <email address hidden>
> Sent: Tuesday, June 25, 2013 2:42:47 AM
> Subject: Re: [Openerp-community] [Merge]
> lp:~sebastien.beau/openerp-product-attributes/openerp-product-attributes-product-dimension into
> lp:openerp-product-attributes
>
> Review: Needs Information
>
> Hi Sébastien,
>
> My impression is that the dimensions should be centimeters.
> At least we should have a configurable precision.
>
> I think you can remove this TODO:
>
> #TODO add a function field for volume? an onchange?
>
> If someone need a 'volume' field, he will add it, would it be an
> onchange or a function field, but I don't see any value for this
> comment.
> --
> https://code.launchpad.net/~sebastien.beau/openerp-product-attributes/openerp-product-attributes-product-dimension/+merge/171181
> Your team OpenERP Community is subscribed to branch
> lp:openerp-product-attributes.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openerp-community
> More help : https://help.launchpad.net/ListHelp
>

« Back to merge proposal