Merge lp:~sebastien.beau/openerp-product-attributes/openerp-product-attributes-product-dimension into lp:~product-core-editors/openerp-product-attributes/7.0
Proposed by
Sébastien BEAU - http://www.akretion.com
Status: | Rejected |
---|---|
Rejected by: | Maxime Chambreuil (http://www.savoirfairelinux.com) |
Proposed branch: | lp:~sebastien.beau/openerp-product-attributes/openerp-product-attributes-product-dimension |
Merge into: | lp:~product-core-editors/openerp-product-attributes/7.0 |
Diff against target: |
140 lines (+120/-0) 4 files modified
product_dimension/__init__.py (+23/-0) product_dimension/__openerp__.py (+34/-0) product_dimension/product.py (+34/-0) product_dimension/product_view.xml (+29/-0) |
To merge this branch: | bzr merge lp:~sebastien.beau/openerp-product-attributes/openerp-product-attributes-product-dimension |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Maxime Chambreuil (http://www.savoirfairelinux.com) | Disapprove | ||
Guewen Baconnier @ Camptocamp | Needs Information | ||
Review via email: mp+171181@code.launchpad.net |
Description of the change
Add a module for adding dimension field on product. Needed for e-commerce
To post a comment you must log in.
Unmerged revisions
- 207. By Sébastien BEAU - http://www.akretion.com
-
[ADD] add product_dimension module
Hi Sébastien,
My impression is that the dimensions should be centimeters.
At least we should have a configurable precision.
I think you can remove this TODO:
#TODO add a function field for volume? an onchange?
If someone need a 'volume' field, he will add it, would it be an onchange or a function field, but I don't see any value for this comment.