map_magento_order is puzzling to me : it can return True or an invoice id, and there's a case where no id is mapped and nothing is logged (case when len(invoice_ids) != 1). This is probably something which should not happen, but I'd rather have a trace of the event.
in create_magento_invoice: s/synchronise/synchronize/ + remove spaces before ':' in english
magerp_core.py
===============
one leftover TODO (non blocking for the review)
product.py
==========
in _get_oe_resources, use iteritems rather than items (avoid generating a useless python list)
product_images.py
=================
not your fault, I could not understand the meaning of the comments at the beginning of the file. If you have a clearer idea of what is meant, clarification is welcome.
These are minor points, no need to resubmit before merging.
invoice.py
==========
map_magento_order is puzzling to me : it can return True or an invoice id, and there's a case where no id is mapped and nothing is logged (case when len(invoice_ids) != 1). This is probably something which should not happen, but I'd rather have a trace of the event.
in create_ magento_ invoice: s/synchronise/ synchronize/ + remove spaces before ':' in english
magerp_core.py
===============
one leftover TODO (non blocking for the review)
product.py
==========
in _get_oe_resources, use iteritems rather than items (avoid generating a useless python list)
product_images.py
=================
not your fault, I could not understand the meaning of the comments at the beginning of the file. If you have a clearer idea of what is meant, clarification is welcome.
These are minor points, no need to resubmit before merging.
Thanks for your work.