Merge lp:~sebastien.beau/e-commerce-addons/e-commerce-addons-fix-automatic-workflow into lp:~extra-addons-commiter/e-commerce-addons/7.0

Proposed by Sébastien BEAU - http://www.akretion.com
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 295
Merged at revision: 295
Proposed branch: lp:~sebastien.beau/e-commerce-addons/e-commerce-addons-fix-automatic-workflow
Merge into: lp:~extra-addons-commiter/e-commerce-addons/7.0
To merge this branch: bzr merge lp:~sebastien.beau/e-commerce-addons/e-commerce-addons-fix-automatic-workflow
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no test Approve
Guewen Baconnier @ Camptocamp Approve
Review via email: mp+218069@code.launchpad.net

Description of the change

Avoid useless testing of order in exception.

Please do not forget to active the cron "test all draft order".

Maybe we should active it by default?

To post a comment you must log in.
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM, thanks!

review: Approve
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

rev 295 LGTM.

I just wonder why this MP is missing the diff :/

review: Approve (code review, no test)
Revision history for this message
Sébastien BEAU - http://www.akretion.com (sebastien.beau) wrote :

No idea I just received a mail saying
"Launchpad encountered an internal error during the following operation: generating the diff for a merge proposal. It was logged with id OOPS-3b8dbe270f99397639ea3998f5cd1857. Sorry for the inconvenience."

:'(

By chance the change is simple and in only one commit

Thanks for the review

Diff calculation failed

Calculating the branch diff failed. You can manually schedule an update if required.

Subscribers

People subscribed via source and target branches