Merge lp:~sebastien.beau/c2c-financial-addons/c2c-financial-addons-fix-rule-m2m into lp:c2c-financial-addons/6.1

Proposed by Guewen Baconnier @ Camptocamp
Status: Merged
Merged at revision: 90
Proposed branch: lp:~sebastien.beau/c2c-financial-addons/c2c-financial-addons-fix-rule-m2m
Merge into: lp:c2c-financial-addons/6.1
Diff against target: 17 lines (+5/-0) (has conflicts)
1 file modified
account_fiscal_position_rule_m2m/fiscal_rules.py (+5/-0)
Text conflict in account_fiscal_position_rule_m2m/fiscal_rules.py
To merge this branch: bzr merge lp:~sebastien.beau/c2c-financial-addons/c2c-financial-addons-fix-rule-m2m
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp Pending
Guewen Baconnier @ Camptocamp Pending
Review via email: mp+131023@code.launchpad.net

This proposal supersedes a proposal from 2012-10-15.

Description of the change

FIX a bug

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote : Posted in a previous version of this proposal

The merge is huge for "a bug". Can you check you requested the merge on the right branch + describe the bug you're trying to fix (or link to a bug on the tracker)?

Thanks

review: Needs Fixing
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote : Posted in a previous version of this proposal

Hi Sébastien,

Please create your merge proposal into lp:c2c-financial-addons/6.1

Thanks

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote : Posted in a previous version of this proposal

Hi Sébastien,

I merged your fix (slightly modified) from the revision 90 in our 6.1 branch.

Thanks

Guewen

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_fiscal_position_rule_m2m/fiscal_rules.py'
2--- account_fiscal_position_rule_m2m/fiscal_rules.py 2012-10-23 14:41:46 +0000
3+++ account_fiscal_position_rule_m2m/fiscal_rules.py 2012-10-23 14:44:25 +0000
4@@ -177,9 +177,14 @@
5 )
6
7 for field in account_fiscal_position_rule.m2o_replaced_fields:
8+<<<<<<< TREE
9 field_name = "%s_ids" % field
10 field_ids = [item.id for item in template[field_name]]
11 vals[field_name] = [(6, 0, field_ids)]
12+=======
13+ field_ids = [item.id for item in template["%s_ids"%field]]
14+ vals["%s_ids"%field] = [(6, 0, field_ids)]
15+>>>>>>> MERGE-SOURCE
16
17 return vals
18

Subscribers

People subscribed via source and target branches

to status/vote changes: