Code review comment for lp:~seb128/xchat-indicator/use-libmessaging-menu

> * 342: Is xchat_plugin_deinit called every time the xchat-gnome process is stopped, or only when disabling the plugin?
> messaging_menu_app_unregister doesn't need to be called on app exit if the app should stay in the messaging menu.
> g_object_unref (mmapp) should be called, though.

good point, I changed for an unref call

> * There's still a LIBINDICATE_REQUIRED variable in configure.ac.

cleaned

> * 141, 166: append_source_with_time (mmapp, id, icon, label, g_get_real_time()) can be written as append_source
> (mmapp, id, icon, label) (i.e. current time is the default if nothing else is given)
> * 102: has_source is not necessary before remove_source

good to know, fixed as well, thanks