Merge lp:~seb128/update-notifier/wayland-no-pkexec into lp:update-notifier

[Sebastien Bacher]

src/crash.c: don't prompt about system reports under wayland, pkexec
doesn't work there

src/crash.c: don't prompt about system reports under wayland, pkexec
doesn't work there

[lp:~seb128/update-notifier/wayland-no-pkexec]

915. By Sebastien Bacher on 2017-09-06

src/crash.c: don't prompt about system reports under wayland, pkexec
doesn't work there

[Brian Murray (brian-murray)]

Is there no alternative to pkexec under wayland? How will system crashes be reported?

[Brian Murray (brian-murray)]

review: Needs Information

[Sebastien Bacher (seb128)]

> Is there no alternative to pkexec under wayland? How will system crashes be reported?

no, that's by design, we are going to improve apport to have it's interface being owned by the user and talking to a privileged backend (same as update-manager)

[Sebastien Bacher (seb128)]

it's not ideal to not report the system crashes but the alternative is to give a password prompt that leads to an apport segfault which triggers another report

[Brian Murray (brian-murray)]

> > Is there no alternative to pkexec under wayland? How will system crashes be
> reported?
>
> no, that's by design, we are going to improve apport to have it's interface
> being owned by the user and talking to a privileged backend (same as update-
> manager)

When you say we here do you mean the desktop team or the foundations team? I haven't heard of this work.

[Sebastien Bacher (seb128)]

> When you say we here do you mean the desktop team or the foundations team? I haven't heard of this work.

"we are going to improve" was meant to be "we are going to need to improve", indeed I don't think that work has been discussed yet but it's probably for foundations since that's the team which maintains it

=== modified file 'debian/changelog'
--- debian/changelog	2017-09-05 21:48:13 +0000
+++ debian/changelog	2017-09-06 11:42:48 +0000
@@ -1,3 +1,10 @@
+update-notifier (3.186) UNRELEASED; urgency=medium
+
+  * src/crash.c: don't prompt about system reports under wayland, pkexec
+    doesn't work there
+
+ -- Sebastien Bacher <[e-mail]>  Wed, 06 Sep 2017 10:10:32 +0200
+
 update-notifier (3.185) artful; urgency=medium
 
   * src/livepatch.c: Use ngettext to correctly handle the plural form, thanks

=== modified file 'src/crash.c'
--- src/crash.c	2013-06-04 14:41:18 +0000
+++ src/crash.c	2017-09-06 11:42:48 +0000
@@ -67,8 +67,12 @@
 {
    g_debug("fire up the crashreport tool");
    // be nice and always ask first before firing up pkexec
-   if (check_system_crashes() && ask_invoke_apport_with_pkexec()) {
-      invoke_with_pkexec(CRASHREPORT_REPORT_APP);
+   if (check_system_crashes()) {
+      // workaround, wayland doesn't allow pkexec use
+      if (g_strcmp0 (g_getenv ("XDG_SESSION_TYPE"), "wayland") == 0)
+         g_debug ("no pkexec for system reports under wayland");
+      else if (ask_invoke_apport_with_pkexec())
+         invoke_with_pkexec(CRASHREPORT_REPORT_APP);
    } else {
       return g_spawn_command_line_async(CRASHREPORT_REPORT_APP, NULL);
    }