Merge lp:~seb128/update-notifier/logs-no-ctime into lp:update-notifier

[Sebastien Bacher]

don't use the logs ctime information to decide if update-manager
needs to be started, the log rotation updates that one which means it's
never getting older than a week and the updater not started

don't use the logs ctime information to decide if update-manager
needs to be started, the log rotation updates that one which means it's
never getting older than a week and the updater not started

[Will Cooke (willcooke)]

LGTM

review: Approve

[Michael Vogt (mvo)]

Thanks, very good catch. Logrotate will set the mtime when rotating, but it can't do anything about the ctime so checking that is actually incorrect and you are right in removing it.

review: Approve

[Michael Hudson-Doyle (mwhudson)]

Is there a reason this hasn't been merged? (I'm patch pilot today so this is why I'm checking). Seems there's agreement to, so I can do it if it's just waiting...

[Sebastien Bacher (seb128)]

@mwhudson, no reason out of the fact that I didn't have slots to go back work on that upload since it was reviewed, I'm going to try to do that this week but if you want to handle it please feel free to do it

[lp:~seb128/update-notifier/logs-no-ctime]

875. By Sebastien Bacher on 2016-06-29

src/update.c:
don't use the logs ctime information to decide if update-manager needs
to be started, the log rotation updates that one which means it's
never getting older than a week and the updater not started
(lp: #356152)

876. By Sebastien Bacher on 2016-06-29

releasing package update-notifier version 3.169

=== modified file 'debian/changelog'
--- debian/changelog	2016-04-12 10:26:52 +0000
+++ debian/changelog	2016-06-29 14:52:02 +0000
@@ -1,3 +1,13 @@
+update-notifier (3.169) yakkety; urgency=medium
+
+  * src/update.c: 
+    don't use the logs ctime information to decide if update-manager needs 
+    to be started, the log rotation updates that one which means it's 
+    never getting older than a week and the updater not started 
+    (lp: #356152)
+
+ -- Sebastien Bacher <[e-mail]>  Wed, 29 Jun 2016 16:48:24 +0200
+
 update-notifier (3.168) xenial; urgency=medium
 
   * Also update motd, at the end of Dpkg-Post run, properly counting how

=== modified file 'src/update.c'
--- src/update.c	2014-01-16 00:26:52 +0000
+++ src/update.c	2016-06-29 14:52:02 +0000
@@ -456,7 +456,7 @@
       }
       for(j=0;j < pglob.gl_pathc; j++) {
 	 const char *log = pglob.gl_pathv[j];
-	 time_t mtime, bctime;
+	 time_t mtime;
 	 gchar *timestamp;
 
 	 if(g_stat(log, &buf) <0) {
@@ -473,12 +473,7 @@
 	 g_debug_update ("mtime from %s: %i (%s)", log, mtime, timestamp);
 	 g_free (timestamp);
 
-	 bctime = buf.st_ctime;
-	 timestamp = readable_timestamp (bctime);
-	 g_debug_update ("ctime from %s: %i (%s)", log, bctime, timestamp);
-	 g_free (timestamp);
-
-	 newest_log_stamp = MAX(MAX(mtime, bctime), newest_log_stamp);
+	 newest_log_stamp = MAX(mtime, newest_log_stamp);
 	 timestamp = readable_timestamp (newest_log_stamp);
 	 g_debug_update ("last_launch from %s: %i (%s)", log, newest_log_stamp, timestamp);
 	 g_free (timestamp);