Merge lp:~seb128/update-manager/livepatch-settings-installed into lp:update-manager

[Sebastien Bacher]

Don't mention livepatch settings when the interface is not installed

Don't mention livepatch settings when the interface is not installed

[Brian Murray (brian-murray)]

This looks good to me but I'm curious - what provides the "software-properties-livepatch.desktop" setting /file?

[Sebastien Bacher (seb128)]

hum, that's a good question. the .desktop/UI is shipped with software-properties-gtk but if that's not installed there is no point having a settings button and that's not specific to livepatch...

[lp:~seb128/update-manager/livepatch-settings-installed]

2860. By Sebastien Bacher on 2020-11-30

rebase on trunk

2861. By Sebastien Bacher on 2020-11-30

check for livepatch the same way as software properties

[Sebastien Bacher (seb128)]

Ok, I finally got to revisit that patch, as your comment pointed out checking for a .desktop from the same source wasn't really useful. What software-properties is doing [1] is to check that the online accounts are available or not. There is already a condition on software-properties to be available, so the change as suggested now show allow the UIs to have a synced state

[1] https://git.launchpad.net/software-properties/tree/softwareproperties/gtk/utils.py#n50

=== modified file 'UpdateManager/Dialogs.py'
--- UpdateManager/Dialogs.py	2020-04-07 12:00:12 +0000
+++ UpdateManager/Dialogs.py	2020-11-30 14:07:29 +0000
@@ -153,12 +153,19 @@
         codename = get_dist()
         return di.is_lts(codename)
 
+    def _has_livepatch_settings_ui(self):
+        try:
+            return Gio.DesktopAppInfo.new('gnome-online-accounts-panel.desktop')
+        except:
+            return None
+
     def on_livepatch_status_ready(self, active, cs, ps, fixes):
         self.set_desc(None)
 
         if not active:
             if self._is_livepatch_supported() and \
                self.settings_button and \
+               self._has_livepatch_settings_ui() and \
                self.settings.get_int('launch-count') >= 4:
                 self.set_desc(_("<b>Tip:</b> You can use Livepatch to "
                                 "keep your computer more secure between "