Merge lp:~seb128/unity/update-apport-hook into lp:unity

Proposed by Sebastien Bacher on 2015-11-27
Status: Merged
Approved by: Marco Trevisan (Treviño) on 2015-11-30
Approved revision: 4037
Merged at revision: 4052
Proposed branch: lp:~seb128/unity/update-apport-hook
Merge into: lp:unity
Diff against target: 32 lines (+10/-15)
1 file modified
debian/source_unity.py (+10/-15)
To merge this branch: bzr merge lp:~seb128/unity/update-apport-hook
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2015-11-30
Marco Trevisan (Treviño) 2015-11-27 Approve on 2015-11-30
Review via email: mp+278774@code.launchpad.net

Commit Message

Updated apport hook to include:
- the compiz and xorg details, not only after asking users if the issue
is a graphical one (which is weird question)
- the upstart logs for unity/ups/lockscreen
- some gsettings configurations

Description of the Change

Updated apport hook to include:
- the compiz and xorg details, not only after asking users if the issue
is a graphical one (which is weird question)
- the upstart logs for unity/ups/lockscreen
- some gsettings configurations

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Marco Trevisan (Treviño) (3v1n0) wrote :

+1

It would be nice to move the data out from libunity-core-6.0-9 though.

review: Approve
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/source_unity.py'
2--- debian/source_unity.py 2012-07-02 13:02:47 +0000
3+++ debian/source_unity.py 2015-11-27 09:41:58 +0000
4@@ -21,18 +21,13 @@
5 report.add_package_info(apport.packaging.get_file_package(words))
6 return
7
8- # only reports all compiz infos if a graphical bug
9- compiz_bug = False
10- if ui and report['SourcePackage'] == "unity":
11- if ui.yesno("Thanks for reporting this bug on unity. Is the issue you are reporting purely graphical (will report more information about your graphic configuration and will report the bug against compiz)?"):
12- compiz_bug = True
13- if compiz_bug:
14- report.add_hooks_info(ui, srcpackage='compiz')
15- else:
16- # still send some info like the plugins activated
17- # Plugins
18- report['CompizPlugins'] = command_output(['gconftool-2',
19- '--get', '/apps/compiz-1/general/screen0/options/active_plugins'])
20-
21- # User configuration
22- report['GconfCompiz'] = command_output(['gconftool-2', '-R', '/apps/compiz-1'])
23+ # Include the compiz details
24+ report.add_hooks_info(ui, srcpackage='compiz')
25+ # the upstart logs
26+ attach_upstart_logs(report, 'unity-services')
27+ attach_upstart_logs(report ,'libunity-core-6.0-9')
28+ # some gsettings configs
29+ attach_gsettings_schema(report, 'com.canonical.Unity')
30+ attach_gsettings_schema(report, 'com.ubuntu.user-interface')
31+ attach_gsettings_schema(report, 'org.gnome.desktop.interface')
32+ attach_gsettings_schema(report, 'org.gnome.desktop.lockdown')