Unity

Merge lp:~seb128/unity/signal-eavedropping-fix into lp:unity

  1. signal-eavedropping-fix
  2. Merge into trunk
Proposed by Sebastien Bacher on 2012-08-02
Status: Merged
Approved by: Sebastien Bacher on 2012-08-03
Approved revision: 2530
Merged at revision: 2538
Proposed branch: lp:~seb128/unity/signal-eavedropping-fix
Merge into: lp:unity
Diff against target: 39 lines (+4/-4)
1 file modified
services/panel-main.c (+4/-4)
To merge this branch: bzr merge lp:~seb128/unity/signal-eavedropping-fix
Reviewer Review Type Date Requested Status
Michal Hruby (community) 2012-08-02 Approve on 2012-08-03
jenkins continuous-integration Pending
Review via email: mp+117931@code.launchpad.net

Commit Message

Don't specify a specific destination for the dbus signals

Description of the Change

Don't specify a specific destination for the dbus signals, that
creates issues with the new dbus eavedropping behaviour,
thanks Neil J. Patel for the fix!

To post a comment you must log in.
Michal Hruby (mhr3) wrote :

Makes sense, that parameter seems to have been used as source, while it's destination.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'services/panel-main.c'
2--- services/panel-main.c 2012-02-13 13:37:24 +0000
3+++ services/panel-main.c 2012-08-02 15:46:27 +0000
4@@ -235,7 +235,7 @@
5 {
6 GError *error = NULL;
7 g_dbus_connection_emit_signal (connection,
8- S_NAME,
9+ NULL,
10 S_PATH,
11 S_IFACE,
12 "ReSync",
13@@ -256,7 +256,7 @@
14 {
15 GError *error = NULL;
16 g_dbus_connection_emit_signal (connection,
17- S_NAME,
18+ NULL,
19 S_PATH,
20 S_IFACE,
21 "EntryActivated",
22@@ -278,7 +278,7 @@
23 GError *error = NULL;
24 g_warning ("%s, entry_id:%s", G_STRFUNC, entry_id);
25 g_dbus_connection_emit_signal (connection,
26- S_NAME,
27+ NULL,
28 S_PATH,
29 S_IFACE,
30 "EntryActivateRequest",
31@@ -300,7 +300,7 @@
32 {
33 GError *error = NULL;
34 g_dbus_connection_emit_signal (connection,
35- S_NAME,
36+ NULL,
37 S_PATH,
38 S_IFACE,
39 "EntryShowNowChanged",