Merge lp:~seb128/unity/dash-preview-translation-fix into lp:unity/7.0

Proposed by Sebastien Bacher
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 3312
Proposed branch: lp:~seb128/unity/dash-preview-translation-fix
Merge into: lp:unity/7.0
Diff against target: 36 lines (+6/-2)
2 files modified
dash/previews/PreviewInfoHintWidget.cpp (+5/-2)
po/POTFILES.in (+1/-0)
To merge this branch: bzr merge lp:~seb128/unity/dash-preview-translation-fix
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Marco Trevisan (Treviño) Approve
Review via email: mp+160360@code.launchpad.net

Commit message

Use '%s:' string for preview hints, rather than just appending ':'

Description of the change

Use '%s:' string for preview hints, rather than just appending ':'

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dash/previews/PreviewInfoHintWidget.cpp'
2--- dash/previews/PreviewInfoHintWidget.cpp 2013-01-16 18:34:18 +0000
3+++ dash/previews/PreviewInfoHintWidget.cpp 2013-04-23 13:12:44 +0000
4@@ -20,6 +20,9 @@
5 *
6 */
7
8+#include "config.h"
9+#include <glib/gi18n-lib.h>
10+
11 #include "PreviewInfoHintWidget.h"
12 #include "unity-shared/IntrospectableWrappers.h"
13 #include <NuxCore/Logger.h>
14@@ -158,8 +161,8 @@
15 StaticCairoTextPtr info_name;
16 if (!info_hint->display_name.empty())
17 {
18- std::string tmp_display_name = info_hint->display_name;
19- tmp_display_name += ":";
20+ // The "%s" is used in the dash preview to display the "<hint>: <value>" infos
21+ std::string tmp_display_name = glib::String(g_strdup_printf (_("%s:"), info_hint->display_name.c_str())).Str();
22
23 info_name = new StaticCairoText(tmp_display_name, true, NUX_TRACKER_LOCATION);
24 info_name->SetFont(style.info_hint_bold_font());
25
26=== modified file 'po/POTFILES.in'
27--- po/POTFILES.in 2013-03-22 12:47:04 +0000
28+++ po/POTFILES.in 2013-04-23 13:12:44 +0000
29@@ -9,6 +9,7 @@
30 dash/PlacesGroup.cpp
31 dash/ResultViewGrid.cpp
32 dash/previews/ApplicationPreview.cpp
33+dash/previews/PreviewInfoHintWidget.cpp
34 dash/previews/SocialPreview.cpp
35 hud/HudController.cpp
36 hud/HudView.cpp

Subscribers

People subscribed via source and target branches

to all changes: