Merge lp:~seb128/unity-settings-daemon/housekeeping-label-width into lp:unity-settings-daemon

Proposed by Sebastien Bacher on 2015-02-05
Status: Merged
Approved by: Sebastien Bacher on 2015-02-05
Approved revision: 4067
Merged at revision: 4067
Proposed branch: lp:~seb128/unity-settings-daemon/housekeeping-label-width
Merge into: lp:unity-settings-daemon
Diff against target: 18 lines (+3/-1)
1 file modified
plugins/housekeeping/gsd-ldsm-dialog.c (+3/-1)
To merge this branch: bzr merge lp:~seb128/unity-settings-daemon/housekeeping-label-width
Reviewer Review Type Date Requested Status
Iain Lane 2015-02-05 Approve on 2015-02-05
Review via email: mp+248729@code.launchpad.net

Commit Message

housekeeping: set labels width, so they wrap instead of stretching the dialog

Description of the Change

housekeeping: set labels width, so they wrap instead of stretching the dialog

reported upstream as well
https://bugzilla.gnome.org/show_bug.cgi?id=744033

To post a comment you must log in.
Iain Lane (laney) wrote :

thx for upstreaming

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/housekeeping/gsd-ldsm-dialog.c'
2--- plugins/housekeeping/gsd-ldsm-dialog.c 2013-01-23 15:41:10 +0000
3+++ plugins/housekeeping/gsd-ldsm-dialog.c 2015-02-05 11:01:59 +0000
4@@ -220,11 +220,13 @@
5 gtk_label_set_line_wrap (GTK_LABEL (dialog->priv->primary_label), TRUE);
6 gtk_label_set_single_line_mode (GTK_LABEL (dialog->priv->primary_label), FALSE);
7 gtk_misc_set_alignment (GTK_MISC (dialog->priv->primary_label), 0.0, 0.0);
8-
9+ gtk_label_set_max_width_chars (GTK_LABEL (dialog->priv->primary_label), 72);
10+
11 dialog->priv->secondary_label = gtk_label_new (NULL);
12 gtk_label_set_line_wrap (GTK_LABEL (dialog->priv->secondary_label), TRUE);
13 gtk_label_set_single_line_mode (GTK_LABEL (dialog->priv->secondary_label), FALSE);
14 gtk_misc_set_alignment (GTK_MISC (dialog->priv->secondary_label), 0.0, 0.0);
15+ gtk_label_set_max_width_chars (GTK_LABEL (dialog->priv->secondary_label), 72);
16
17 /* Create the check button to ignore future warnings */
18 dialog->priv->ignore_check_button = gtk_check_button_new ();

Subscribers

People subscribed via source and target branches