Unity Control Center

Merge lp:~seb128/unity-control-center/users-prompt-when-needed into lp:unity-control-center

  1. users-prompt-when-needed
  2. Merge into trunk
Proposed by Sebastien Bacher
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 12757
Merged at revision: 12758
Proposed branch: lp:~seb128/unity-control-center/users-prompt-when-needed
Merge into: lp:unity-control-center
Diff against target: 18 lines (+1/-1)
1 file modified
panels/user-accounts/um-password-dialog.c (+1/-1)
To merge this branch: bzr merge lp:~seb128/unity-control-center/users-prompt-when-needed
Reviewer Review Type Date Requested Status
Allison Karlitskaya (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Unity Control Center development team Pending
Review via email: mp+211596@code.launchpad.net

Commit message

users: don't make accountsservice calls when not needed

Description of the change

users: don't make accountsservice calls when not needed

when changing your own password the "passwd" command is used rather than using accountsservice, in that case avoid making a call to a-s since it leads to unwanted polkit auth dialogs

the issue is mentioned on https://bugzilla.gnome.org/show_bug.cgi?id=701701 as well

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:12757
http://jenkins.qa.ubuntu.com/job/unity-control-center-ci/76/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-amd64-ci/76
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-armhf-ci/76
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-i386-ci/77

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-control-center-ci/76/rebuild

review: Approve (continuous-integration)
Revision history for this message
Allison Karlitskaya (desrt) wrote :

I recommended doing this, so +1 from me :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'panels/user-accounts/um-password-dialog.c'
2--- panels/user-accounts/um-password-dialog.c 2014-02-21 15:48:18 +0000
3+++ panels/user-accounts/um-password-dialog.c 2014-03-18 18:10:02 +0000
4@@ -233,7 +233,6 @@
5
6 switch (mode) {
7 case UM_PASSWORD_DIALOG_MODE_NORMAL:
8- act_user_set_password_mode (um->user, ACT_USER_PASSWORD_MODE_REGULAR);
9 if (act_user_get_uid (um->user) == getuid ()) {
10 GdkDisplay *display;
11 GdkCursor *cursor;
12@@ -253,6 +252,7 @@
13 return;
14 }
15
16+ act_user_set_password_mode (um->user, ACT_USER_PASSWORD_MODE_REGULAR);
17 act_user_set_password (um->user, password, hint);
18 break;
19

Subscribers

People subscribed via source and target branches