Merge lp:~seb128/unity-control-center/user-graphical-sessions into lp:unity-control-center

Proposed by Sebastien Bacher on 2014-03-11
Status: Merged
Approved by: Sebastien Bacher on 2014-03-13
Approved revision: 12748
Merged at revision: 12750
Proposed branch: lp:~seb128/unity-control-center/user-graphical-sessions
Merge into: lp:unity-control-center
Diff against target: 15 lines (+2/-4)
1 file modified
panels/user-accounts/um-history-dialog.c (+2/-4)
To merge this branch: bzr merge lp:~seb128/unity-control-center/user-graphical-sessions
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve on 2014-03-11
Robert Ancell 2014-03-11 Approve on 2014-03-11
Review via email: mp+210510@code.launchpad.net

Commit message

don't list pts sessions in the user login history

Description of the change

don't list pts sessions in the user login history

To post a comment you must log in.
Robert Ancell (robert-ancell) wrote :

I think you mean pts not tty. You could also drop the tty sessions too now that is fixed in LightDM.

review: Approve
Sebastien Bacher (seb128) wrote :

> I think you mean pts not tty.

right, edited the commit messages, thanks

> You could also drop the tty sessions too now that is fixed in LightDM.

GNOME is listing them for some reason, let's stick to what they are doing?

Robert Ancell (robert-ancell) wrote :

> > You could also drop the tty sessions too now that is fixed in LightDM.
>
> GNOME is listing them for some reason, let's stick to what they are doing?

According to that bug report they only did that to work with LightDM

12748. By Sebastien Bacher on 2014-03-12

list only graphical sessions in the user login history

Sebastien Bacher (seb128) wrote :

ok, updated to only include graphical sessions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'panels/user-accounts/um-history-dialog.c'
2--- panels/user-accounts/um-history-dialog.c 2014-02-24 09:46:04 +0000
3+++ panels/user-accounts/um-history-dialog.c 2014-03-12 17:38:55 +0000
4@@ -237,10 +237,8 @@
5 break;
6 }
7
8- /* Display only x-session and tty records */
9- if (!g_str_has_prefix (history.type, ":") &&
10- !g_str_has_prefix (history.type, "tty")&&
11- !g_str_has_prefix (history.type, "pts")) {
12+ /* Display only x-session records */
13+ if (!g_str_has_prefix (history.type, ":")) {
14 continue;
15 }
16

Subscribers

People subscribed via source and target branches