Merge lp:~seb128/unity-control-center/sound-better-icon into lp:unity-control-center

Proposed by Sebastien Bacher on 2016-02-09
Status: Merged
Approved by: Iain Lane on 2016-02-12
Approved revision: 12847
Merged at revision: 12849
Proposed branch: lp:~seb128/unity-control-center/sound-better-icon
Merge into: lp:unity-control-center
Diff against target: 59 lines (+24/-0)
4 files modified
configure.ac (+2/-0)
panels/sound/data/icons/256x256/Makefile.am (+3/-0)
panels/sound/data/icons/256x256/apps/Makefile.am (+18/-0)
panels/sound/data/icons/Makefile.am (+1/-0)
To merge this branch: bzr merge lp:~seb128/unity-control-center/sound-better-icon
Reviewer Review Type Date Requested Status
Iain Lane 2016-02-09 Approve on 2016-02-12
Review via email: mp+285452@code.launchpad.net

Commit message

Include a better resolution unity-sound-panel icon

Description of the change

Include a better resolution unity-sound-panel icon

(open the sound panel and alt-tab on unity, see how the current icon is low quality, the update fixes that)

To post a comment you must log in.
Iain Lane (laney) wrote :

I don't get it - the icon you added is actually 48×48

review: Needs Information
12847. By Sebastien Bacher on 2016-02-12

with the correct icon it's better

Sebastien Bacher (seb128) wrote :

sorry, I tried several variant and back to the old icon to see the difference, looks like I mixed the versions ... updated with the correct one now, thanks for catching the error!

Iain Lane (laney) wrote :

what a great looking icon!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2015-12-14 10:09:05 +0000
3+++ configure.ac 2016-02-12 10:08:53 +0000
4@@ -455,6 +455,8 @@
5 panels/sound/data/icons/48x48/Makefile
6 panels/sound/data/icons/48x48/apps/Makefile
7 panels/sound/data/icons/48x48/devices/Makefile
8+panels/sound/data/icons/256x256/Makefile
9+panels/sound/data/icons/256x256/apps/Makefile
10 panels/sound/data/icons/scalable/Makefile
11 panels/sound/data/icons/scalable/devices/Makefile
12 panels/screen/Makefile
13
14=== added directory 'panels/sound/data/icons/256x256'
15=== added file 'panels/sound/data/icons/256x256/Makefile.am'
16--- panels/sound/data/icons/256x256/Makefile.am 1970-01-01 00:00:00 +0000
17+++ panels/sound/data/icons/256x256/Makefile.am 2016-02-12 10:08:53 +0000
18@@ -0,0 +1,3 @@
19+SUBDIRS = apps
20+
21+-include $(top_srcdir)/git.mk
22
23=== added directory 'panels/sound/data/icons/256x256/apps'
24=== added file 'panels/sound/data/icons/256x256/apps/Makefile.am'
25--- panels/sound/data/icons/256x256/apps/Makefile.am 1970-01-01 00:00:00 +0000
26+++ panels/sound/data/icons/256x256/apps/Makefile.am 2016-02-12 10:08:53 +0000
27@@ -0,0 +1,18 @@
28+NULL =
29+
30+themedir = $(datadir)/icons/hicolor
31+size = 256x256
32+context = apps
33+
34+iconsdir = $(themedir)/$(size)/$(context)
35+
36+icons_DATA = \
37+ unity-sound-panel.png \
38+ $(NULL)
39+
40+EXTRA_DIST = \
41+ $(icons_DATA) \
42+ $(NULL)
43+
44+
45+-include $(top_srcdir)/git.mk
46
47=== added file 'panels/sound/data/icons/256x256/apps/unity-sound-panel.png'
48Binary files panels/sound/data/icons/256x256/apps/unity-sound-panel.png 1970-01-01 00:00:00 +0000 and panels/sound/data/icons/256x256/apps/unity-sound-panel.png 2016-02-12 10:08:53 +0000 differ
49=== modified file 'panels/sound/data/icons/Makefile.am'
50--- panels/sound/data/icons/Makefile.am 2010-10-30 18:48:55 +0000
51+++ panels/sound/data/icons/Makefile.am 2016-02-12 10:08:53 +0000
52@@ -7,6 +7,7 @@
53 24x24 \
54 32x32 \
55 48x48 \
56+ 256x256 \
57 $(NULL)
58
59 -include $(top_srcdir)/git.mk

Subscribers

People subscribed via source and target branches