Code review comment for lp:~seb128/unity-control-center/bluetooth-leftover-button

Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks, I guess that could be improved, I cherry picked that bit from upstream https://git.gnome.org/browse/gnome-control-center/commit/?&id=6b95bb27d81f56acc74c99dd3e131e8b228b8209

seems the code is still the same in trunk
https://git.gnome.org/browse/gnome-control-center/tree/panels/bluetooth/cc-bluetooth-panel.c?id=6b95bb27d81f56acc74c99dd3e131e8b228b8209#n353

I'm going to SRU the no-refactoring version but feel free to block that mp if you think the code should be improvement in the same landing (needs to create a bug upstream/suggest a patch/backport that, so it's going to take a bit longer but that's fine we are early in the cycle)

« Back to merge proposal