Ubuntu UI Toolkit

Merge lp:~seb128/ubuntu-ui-toolkit/gettext-application-name into lp:ubuntu-ui-toolkit/staging

  1. gettext-application-name
  2. Merge into staging
Proposed by Sebastien Bacher on 2015-02-13
Status: Merged
Approved by: Christian Dywan on 2015-02-20
Approved revision: 1410
Merged at revision: 1416
Proposed branch: lp:~seb128/ubuntu-ui-toolkit/gettext-application-name
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 13 lines (+2/-1)
1 file modified
modules/Ubuntu/Components/MainView.qdoc (+2/-1)
To merge this branch: bzr merge lp:~seb128/ubuntu-ui-toolkit/gettext-application-name
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2015-02-20
Christian Dywan 2015-02-13 Approve on 2015-02-20
Review via email: mp+249665@code.launchpad.net

Commit Message

document that MainView's applicationName is used to set the gettext domain

Description of the Change

document that MainView's applicationName is used to set the gettext domain

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1410
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1442/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1360
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/169
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/172
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/172/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/169
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1200
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1358
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1358/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18060

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1442/rebuild

review: Needs Fixing (continuous-integration)
Christian Dywan (kalikiana) wrote :

Nice addition! Thanks for adding that!

review: Approve
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/MainView.qdoc'
2--- modules/Ubuntu/Components/MainView.qdoc 2015-02-12 11:19:57 +0000
3+++ modules/Ubuntu/Components/MainView.qdoc 2015-02-13 15:02:09 +0000
4@@ -95,7 +95,8 @@
5 The property holds the application's name, which must be the same as the
6 desktop file's name.
7 The name also sets the name of the QCoreApplication and defaults for data
8- and cache folders that work on the desktop and under confinement.
9+ and cache folders that work on the desktop and under confinement, as well as
10+ the default gettext domain.
11 C++ code that writes files may use QStandardPaths::writableLocation with
12 QStandardPaths::DataLocation or QStandardPaths::CacheLocation.
13 */

Subscribers

People subscribed via source and target branches