Merge lp:~seb128/ubuntu-ui-toolkit/correct-translation-quoting into lp:ubuntu-ui-toolkit

[Sebastien Bacher]

don't use simple quotes around translatable strings, xgetting ignore those

don't use simple quotes around translatable strings, xgetting ignore those

[Sebastien Bacher (seb128)]

the "Delete" string is not listed in the current template (running update-po.sh doesn't change that), it is with the double quotes in use though

[David Planella (dpm)]

LGTM, thanks!

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1104
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/2159/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5290
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3832
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-utopic-amd64-ci/105
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-utopic-armhf-ci/105
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-utopic-armhf-ci/105/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5012
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6542
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6542/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13886
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3215
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4143
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4143/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-toolkit-ci/2159/rebuild

review: Needs Fixing (continuous-integration)

[Cris Dywan (kalikiana)]

Sensible.

review: Approve

[lp:~seb128/ubuntu-ui-toolkit/correct-translation-quoting]

1268. By Cris Dywan on 2014-09-30

Hide pop over when changing orientation. Fixes: https://bugs.launchpad.net/bugs/1369506, https://bugs.launchpad.net/bugs/1375837.

Approved by PS Jenkins bot, Tim Peeters.

1269. By Tim Peeters on 2014-09-30

Implement header animations in PageHeadStyle and prepare PageStack for enabling the animations.

Approved by PS Jenkins bot, Zsombor Egri.

1270. By Cris Dywan on 2014-10-01

autopilot package should source-depend on QML plugin. Fixes: https://bugs.launchpad.net/bugs/1236085.

Approved by PS Jenkins bot, Zoltan Balogh.

[Cris Dywan (kalikiana)]

I just now spotted this request is wrong, you need to propose against staging!

review: Needs Fixing

[lp:~seb128/ubuntu-ui-toolkit/correct-translation-quoting]

1271. By Sebastien Bacher on 2014-10-02

don't use simple quotes around translatable strings, xgetting ignore those

Unmerged revisions

=== modified file 'modules/Ubuntu/Components/ListItems/Empty.qml'
--- modules/Ubuntu/Components/ListItems/Empty.qml	2014-09-09 16:03:39 +0000
+++ modules/Ubuntu/Components/ListItems/Empty.qml	2014-09-29 17:29:23 +0000
@@ -410,7 +410,7 @@
                         width: units.gu(5)
                     }
                     Label {
-                        text: i18n.dtr('ubuntu-ui-toolkit', 'Delete')
+                        text: i18n.dtr('ubuntu-ui-toolkit', "Delete")
                         verticalAlignment: Text.AlignVCenter
                         anchors {
                             verticalCenter: parent.verticalCenter

=== modified file 'modules/Ubuntu/Components/ToolbarItems.qml'
--- modules/Ubuntu/Components/ToolbarItems.qml	2014-05-23 09:27:57 +0000
+++ modules/Ubuntu/Components/ToolbarItems.qml	2014-09-29 17:29:23 +0000
@@ -139,7 +139,7 @@
     property Item back: ToolbarButton {
         objectName: "back_toolbar_button"
         iconSource: Qt.resolvedUrl("artwork/back.png")
-        text: i18n.dtr('ubuntu-ui-toolkit', 'Back')
+        text: i18n.dtr('ubuntu-ui-toolkit', "Back")
         visible: toolbarItems.pageStack && toolbarItems.pageStack.depth > 1
         /*!
           If there is a \l PageStack of sufficient depth, triggering the back button

=== modified file 'tests/unit/tst_i18n/src/LocalizedApp.qml'
--- tests/unit/tst_i18n/src/LocalizedApp.qml	2014-04-23 08:50:20 +0000
+++ tests/unit/tst_i18n/src/LocalizedApp.qml	2014-09-29 17:29:23 +0000
@@ -24,7 +24,7 @@
 
     Page {
         objectName: 'page'
-        title: i18n.dtr('localizedApp', 'Welcome')
+        title: i18n.dtr('localizedApp', "Welcome")
         Button {
             objectName: 'button'
             anchors.centerIn: parent