Merge lp:~seb128/ubuntu-test-cases/desktop-minimal-install into lp:ubuntu-test-cases/desktop

[Sebastien Bacher]

The code is copied from the existing oem_pkg_installed sightly tweaked

[lp:~seb128/ubuntu-test-cases/desktop-minimal-install]

70. By Sebastien Bacher on 2023-04-17

New desktop minimal install testcase

Ensure that the installed system correctly exclude packages

[Paride Legovini (paride)]

I find some messages a bit confusing ("Not all packages have been found and are not installed"), but I see that's what we had already. The diff LGTM.

review: Approve

=== added file 'preseeds/default_minimal.yaml'
--- preseeds/default_minimal.yaml	1970-01-01 00:00:00 +0000
+++ preseeds/default_minimal.yaml	2023-04-17 21:53:56 +0000
@@ -0,0 +1,20 @@
+identity:
+  hostname: utah-hostname
+  password: "$y$j9T$nSo5WE2iVRpZQTf1zdNMA1$aFwGMR.afMfV2ouu9tTfP5.r81iCVcBjIa2chzWIYc7"
+  username: utah
+packages:
+  - openssh-server
+  - python3-yaml
+  - bzr
+  - git
+  - gdebi-core
+  - python3-psutil
+early-commands: 
+  - chmod 666 /dev/ttyS0
+  - echo "AutoLoginUser=utah" > /tmp/ubuntu_desktop_installer.conf
+late-commands:
+  - sh /utah-latecommand
+  - curtin in-target -- sh /etc/utah/autorun/01_utah-setup
+source:
+  id: ubuntu-desktop-minimal
+version: 1

=== added file 'runlists/default_minimal.run'
--- runlists/default_minimal.run	1970-01-01 00:00:00 +0000
+++ runlists/default_minimal.run	2023-04-17 21:53:56 +0000
@@ -0,0 +1,8 @@
+testsuites:
+  - name: usit
+    fetch_method: bzr-export
+    fetch_location: https://code.launchpad.net/ubuntu-test-cases/desktop/testsuites/usit
+    include_tests:
+      - read_write
+      - dbus_machine_id
+      - minimal_install

=== added directory 'testsuites/usit/minimal_install'
=== added file 'testsuites/usit/minimal_install/tc_control'
--- testsuites/usit/minimal_install/tc_control	1970-01-01 00:00:00 +0000
+++ testsuites/usit/minimal_install/tc_control	2023-04-17 21:53:56 +0000
@@ -0,0 +1,12 @@
+description: the minimal install should have packages not installed
+dependencies: none
+action: |
+ 1. Look for packages in apt cache
+ 2. Get installation status for package
+ 3. Iterate over the list of packages that shouldn't be installed
+expected_results: |
+ 1. Package is found in apt cache
+ 2. Package is not installed
+type: userland
+command: ./test.py
+run_as: utah

=== added file 'testsuites/usit/minimal_install/test.py'
--- testsuites/usit/minimal_install/test.py	1970-01-01 00:00:00 +0000
+++ testsuites/usit/minimal_install/test.py	2023-04-17 21:53:56 +0000
@@ -0,0 +1,74 @@
+#!/usr/bin/python3
+#
+# Copyright (C) 2023, Canonical Ltd (http://www.canonical.com/)
+#
+# This file is part of ubuntu-test-cases.
+#
+# ubuntu-test-cases is free software: you can redistribute it
+# and/or modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation, either version 3 of
+# the License, or (at your option) any later version.
+#
+# ubuntu-test-cases is distributed in the hope that it will
+# be useful, but WITHOUT ANY WARRANTY; without even the implied warranty
+# of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with ubuntu-test-cases.  If not, see
+# <http://www.gnu.org/licenses/>.
+
+"""Minimal install packages are not installed."""
+
+import logging
+import unittest
+import apt
+
+
+class MinimalInstall(unittest.TestCase):
+    PACKAGE_NAMES = (
+        "thunderbird",
+        "transmission-gtk",
+        "rhythmbox",
+        "gnome-sudoku",
+        "totem",
+        "shotwell",
+        "libreoffice-writer",
+    )
+
+    def test_minimal_install(self):
+        """minimal install packages are not installed."""
+        logging.info('Getting apt cache...')
+        cache = apt.cache.Cache()
+
+        def check_installed(package_name):
+            """
+            Check a single package
+            """
+            logging.info('Checking if {!r} is in cache...'
+                         .format(package_name))
+            if package_name not in cache:
+                logging.error('{!r} not found in the cache'
+                              .format(package_name))
+                return False
+
+            logging.info('Checking if {!r} is not installed...'
+                         .format(package_name))
+            package = cache[package_name]
+            if package.is_installed:
+                logging.error('{!r} is installed'
+                              .format(package_name))
+                return False
+            return True
+
+        installed = [check_installed(package_name)
+                     for package_name in self.PACKAGE_NAMES]
+        if not all(installed):
+            raise AssertionError('Not all packages have been found '
+                                 'and are not installed')
+
+
+if __name__ == '__main__':
+    logging.basicConfig(level=logging.DEBUG,
+                        format='%(levelname)s: %(message)s')
+    unittest.main()

=== modified file 'testsuites/usit/tslist.run'
--- testsuites/usit/tslist.run	2023-04-17 15:59:09 +0000
+++ testsuites/usit/tslist.run	2023-04-17 21:53:56 +0000
@@ -13,3 +13,4 @@
 - test: out_of_memory
 - test: archive_location
 - test: system_localized
+- test: minimal_install