Merge lp:~seb128/ubuntu-system-settings/updates-ellipsize-labels into lp:ubuntu-system-settings

Proposed by Sebastien Bacher
Status: Merged
Approved by: Iain Lane
Approved revision: 1143
Merged at revision: 1147
Proposed branch: lp:~seb128/ubuntu-system-settings/updates-ellipsize-labels
Merge into: lp:ubuntu-system-settings
Diff against target: 34 lines (+5/-1)
1 file modified
plugins/system-update/PageComponent.qml (+5/-1)
To merge this branch: bzr merge lp:~seb128/ubuntu-system-settings/updates-ellipsize-labels
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Iain Lane Approve
Review via email: mp+238955@code.launchpad.net

Commit message

[system-update] ellipsize labels if needed

Description of the change

[system-update] ellipsize labels if needed

To post a comment you must log in.
1142. By Sebastien Bacher

[system-update] ellipsize labels if needed

1143. By Sebastien Bacher

ellipsize even if there is no button displayed

Revision history for this message
Iain Lane (laney) wrote :

Thanks, this looks good!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/system-update/PageComponent.qml'
2--- plugins/system-update/PageComponent.qml 2014-10-08 15:51:44 +0000
3+++ plugins/system-update/PageComponent.qml 2014-10-20 20:56:22 +0000
4@@ -453,11 +453,12 @@
5 objectName: "labelTitle"
6 anchors {
7 left: parent.left
8+ right: buttonAppUpdate.visible ? buttonAppUpdate.left : parent.right
9 verticalCenter: parent.verticalCenter
10 }
11 text: modelData.title
12 font.bold: true
13- elide: buttonAppUpdate.visible ? Text.ElideRight : Text.ElideNone
14+ elide: Text.ElideMiddle
15 }
16
17 Button {
18@@ -514,6 +515,8 @@
19 Label {
20 objectName: "labelUpdateStatus"
21 anchors.left: parent.left
22+ anchors.right: updateStatusLabel.left
23+ elide: Text.ElideMiddle
24 fontSize: "small"
25 text: {
26 if (retry)
27@@ -526,6 +529,7 @@
28 }
29 }
30 Label {
31+ id: updateStatusLabel
32 anchors.right: parent.right
33 visible: !labelSize.visible && !installing && !installed
34 fontSize: "small"

Subscribers

People subscribed via source and target branches