Merge lp:~seb128/ubuntu-system-settings/sound-keyboard-backend into lp:ubuntu-system-settings

Proposed by Sebastien Bacher
Status: Merged
Approved by: Ken VanDine
Approved revision: 1020
Merged at revision: 1027
Proposed branch: lp:~seb128/ubuntu-system-settings/sound-keyboard-backend
Merge into: lp:ubuntu-system-settings
Diff against target: 35 lines (+6/-5)
1 file modified
plugins/sound/PageComponent.qml (+6/-5)
To merge this branch: bzr merge lp:~seb128/ubuntu-system-settings/sound-keyboard-backend
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+234078@code.launchpad.net

Commit message

[sound] use the correct backend to control the keyboard sound toggle

Description of the change

[sound] use the correct backend to control the keyboard sound toggle

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Works great

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/sound/PageComponent.qml'
2--- plugins/sound/PageComponent.qml 2014-08-28 17:33:40 +0000
3+++ plugins/sound/PageComponent.qml 2014-09-10 09:50:01 +0000
4@@ -23,7 +23,6 @@
5 import Ubuntu.Components 0.1
6 import Ubuntu.Components.ListItems 0.1 as ListItem
7 import SystemSettings 1.0
8-import Ubuntu.SystemSettings.LanguagePlugin 1.0
9 import Ubuntu.SystemSettings.Sound 1.0
10 import Ubuntu.Settings.Menus 0.1 as Menus
11 import QMenuModel 0.1
12@@ -40,8 +39,10 @@
13
14 UbuntuSoundPanel { id: backendInfo }
15
16- UbuntuLanguagePlugin {
17- id: languagePlugin
18+ GSettings {
19+ id: keyboardSettings
20+
21+ schema.id: "com.canonical.keyboard.maliit"
22 }
23
24 GSettings {
25@@ -196,9 +197,9 @@
26
27 control: Switch {
28 objectName: "keyboardSoundSwitch"
29- checked: languagePlugin.keyPressFeedback
30+ checked: keyboardSettings.keyPressFeedback
31
32- onClicked: languagePlugin.keyPressFeedback = checked
33+ onClicked: keyboardSettings.keyPressFeedback = checked
34 }
35 }
36

Subscribers

People subscribed via source and target branches