Merge lp:~seb128/ubuntu-system-settings/set-correct-application-name into lp:ubuntu-system-settings
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Iain Lane | ||||
Approved revision: | 1304 | ||||
Merged at revision: | 1305 | ||||
Proposed branch: | lp:~seb128/ubuntu-system-settings/set-correct-application-name | ||||
Merge into: | lp:ubuntu-system-settings | ||||
Diff against target: |
12 lines (+1/-1) 1 file modified
src/qml/MainWindow.qml (+1/-1) |
||||
To merge this branch: | bzr merge lp:~seb128/ubuntu-system-settings/set-correct-application-name | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Iain Lane | Approve | ||
PS Jenkins bot | continuous-integration | Needs Fixing | |
Review via email: mp+249613@code.launchpad.net |
Commit message
change applicationName MainView's property to be "ubuntu-
rather than "SystemSettings", the documentation says it should match the
desktop file name. The toolkit also sets the textdomain to that value
which leads to translation issues, even if the domain is changed again
later on, since glib does some init based on the return value of the first
call to g_dgettext for example
Description of the change
change applicationName MainView's property to be "ubuntu-
rather than "SystemSettings", the documentation says it should match the
desktop file name. The toolkit also sets the textdomain to that value
which leads to translation issues, even if the domain is changed again
later on, since glib does some init based on the return value of the first
call to g_dgettext for example
FAILED: Continuous integration, rev:1304 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- ci/1968/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 1348 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- vivid-i386- ci/238 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 1188 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1346 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1346/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 18043
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- system- settings- ci/1968/ rebuild
http://