Merge lp:~seb128/ubuntu-system-settings/security-use-ctr into lp:ubuntu-system-settings

Proposed by Sebastien Bacher on 2015-02-05
Status: Merged
Approved by: Ken VanDine on 2015-02-06
Approved revision: 1292
Merged at revision: 1294
Proposed branch: lp:~seb128/ubuntu-system-settings/security-use-ctr
Merge into: lp:ubuntu-system-settings
Diff against target: 38 lines (+3/-3)
3 files modified
debian/control (+1/-1)
plugins/security-privacy/PhoneLocking.qml (+1/-1)
po/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~seb128/ubuntu-system-settings/security-use-ctr
Reviewer Review Type Date Requested Status
Ken VanDine 2015-02-05 Approve on 2015-02-06
PS Jenkins bot continuous-integration Needs Fixing on 2015-02-05
Review via email: mp+248771@code.launchpad.net

Commit Message

security: use new i18n.ctr rather than qsTr which doesn't use gettext

Description of the Change

security: use new i18n.ctr rather than qsTr which doesn't use gettext

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-01-30 18:09:06 +0000
3+++ debian/control 2015-02-09 15:43:26 +0000
4@@ -76,7 +76,7 @@
5 qtdeclarative5-systeminfo-plugin,
6 qtdeclarative5-ubuntu-content1,
7 qtdeclarative5-ubuntu-settings-components (>> 0.2),
8- qtdeclarative5-ubuntu-ui-toolkit-plugin (>= 1.1.1239) | qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (>= 1.1.1239),
9+ qtdeclarative5-ubuntu-ui-toolkit-plugin (>= 1.1.1347) | qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (>= 1.1.1347),
10 suru-icon-theme,
11 whoopsie-preferences (>= 0.9),
12 libsystemsettings1 (= ${binary:Version}),
13
14=== modified file 'plugins/security-privacy/PhoneLocking.qml'
15--- plugins/security-privacy/PhoneLocking.qml 2014-11-04 12:08:12 +0000
16+++ plugins/security-privacy/PhoneLocking.qml 2015-02-09 15:43:26 +0000
17@@ -42,7 +42,7 @@
18 anchors.right: parent.right
19
20 ListItem.SingleValue {
21- property string swipe: qsTr("None", "Unlock with swipe")
22+ property string swipe: i18n.ctr("Unlock with swipe", "None")
23 property string passcode: i18n.tr("Passcode")
24 property string passphrase: i18n.tr("Passphrase")
25
26
27=== modified file 'po/CMakeLists.txt'
28--- po/CMakeLists.txt 2014-09-11 16:08:04 +0000
29+++ po/CMakeLists.txt 2015-02-09 15:43:26 +0000
30@@ -42,7 +42,7 @@
31 --copyright=\"Canonical Ltd.\"
32 --package-name ubuntu-system-settings
33 --qt --c++ --add-comments=TRANSLATORS
34- --keyword=QT_TR_NOOP --keyword=qsTr:1,2c
35+ --keyword=QT_TR_NOOP --keyword=ctr:1c,2
36 --keyword=tr --keyword=tr:1,2 --from-code=UTF-8
37 ${QMLFILES} "${CMAKE_CURRENT_BINARY_DIR}/settings.js"
38 WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"

Subscribers

People subscribed via source and target branches