lp:~seb128/ubuntu-system-settings/security-confirmation-enabled
- Get this branch:
- bzr branch lp:~seb128/ubuntu-system-settings/security-confirmation-enabled
Branch merges
- Ken VanDine: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 28 lines (+17/-1)1 file modifiedplugins/security-privacy/LockSecurity.qml (+17/-1)
Related bugs
Related blueprints
Branch information
Recent revisions
- 1280. By Sebastien Bacher
-
[security-privacy] enable the confirmation button only in the cases
described by the specification - 1279. By Launchpad Translations on behalf of system-settings-touch
-
Launchpad automatic translations update.
- 1277. By Jonas G. Drange
-
[wifi] updates AP test because of a new backend
Approved by: Ken VanDine, PS Jenkins bot - 1276. By Jonas G. Drange
-
[ap] avoid use of scroll_to_and_click where the element to be clicked is visible without scrolling
Approved by: Ken VanDine - 1275. By Michael Terry
-
Revoke any cached authorizations before trying to change password mode. This makes sure that we authenticate the user again even if we just did so (for UX consistency).
Note that this is kind of an involved change:
- I took out the trySetSecurity call which doesn't make sense anymore if we don't allow cached authorization.
- I changed the policykit agent to register as a session-wide agent (not just for the system-settings process). This is because polkitd does not yet allow you to revoke cached authorizations for processes. Registering and revoking as a session-wide agent should be fine.
- I also had to use the call to revoke all authorizations. There is a more targeted call, to only remove one authorization, by ID. But polkitd didn't let me find the authorization ID when I queried for it. So... I figured just revoking all of them was fine. We are changing the password after all. Either the user changes it and it makes sense to revoke all auths from the old password or the user fails to change it and it makes sense to revoke all auths as a security measure (some non-owner is holding the phone). Between the problems revoking-by-process and revoking-by-ID, I get the sense that the revokation API isn't often used.
- Adding more calls to the policykit agent made it more noticeable that we were using a blocking call to wait for the agent to finish. That's bad UX. So I changed system-settings to call QCoreApplicatio
n::processEvent s every now and then while waiting. - Now that Qt was processing events while waiting, I had introduced a new problem: the user can interact with the main page (even pressing the "back" button) while the dialog is waiting -- you can see this by going to landscape mode). So I made sure that the page and back button are disabled while the dialog is up. (And to get access to the back button, I had to bump the Ubuntu.Components API version to 1.1 to get the 'head' property on a Page.) Fixes: #1371655
Approved by: Ken VanDine, PS Jenkins bot - 1273. By Alberto Mardegan
-
Security: ignore older requests when building the applications' grants
Also update the unit tests to ensure that we'll compute the same results no matter what the order of the rows is. Fixes: #1387734
Approved by: Sebastien Bacher, Thomas Voß - 1271. By Sebastien Bacher
-
security-privacy: give default focus to the first entry Fixes: #1412530
Approved by: Ken VanDine, PS Jenkins bot
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:ubuntu-system-settings