Merge lp:~seb128/ubuntu-system-settings/license-use-standard-text into lp:ubuntu-system-settings

Proposed by Sebastien Bacher
Status: Merged
Approved by: Iain Lane
Approved revision: 641
Merged at revision: 646
Proposed branch: lp:~seb128/ubuntu-system-settings/license-use-standard-text
Merge into: lp:ubuntu-system-settings
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/about/License.qml (+1/-1)
To merge this branch: bzr merge lp:~seb128/ubuntu-system-settings/license-use-standard-text
Reviewer Review Type Date Requested Status
Iain Lane Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+209242@code.launchpad.net

Commit message

license: use Label widget instead of Text, it looks more integrated

Description of the change

license: use Label widget instead of Text, it looks more integrated

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

(resubmitting using Label, that's the recommended widget here)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Iain Lane (laney) wrote :

(Why is there an unmerged translation update here?)

Looks fine, I tried it and it's more readable. Thanks.

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

> (Why is there an unmerged translation update here?)

dunno, weird, it's not creating any diff though so seems alright...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/about/License.qml'
2--- plugins/about/License.qml 2014-02-27 21:17:09 +0000
3+++ plugins/about/License.qml 2014-03-04 12:51:57 +0000
4@@ -25,7 +25,7 @@
5 otherwise the UI might end up in a situation where scrolling doesn't work */
6 flickableDirection: Flickable.VerticalFlick
7
8- Text {
9+ Label {
10 id: textId
11 text: backendInfo.licenseInfo(binary)
12 width: scrollWidget.width

Subscribers

People subscribed via source and target branches