Merge lp:~seb128/ubuntu-system-settings/dont-install-example into lp:ubuntu-system-settings

Proposed by Sebastien Bacher
Status: Merged
Approved by: Ken VanDine
Approved revision: 82
Merged at revision: 84
Proposed branch: lp:~seb128/ubuntu-system-settings/dont-install-example
Merge into: lp:ubuntu-system-settings
Diff against target: 43 lines (+1/-13)
3 files modified
debian/control (+1/-10)
debian/ubuntu-system-settings-example.install (+0/-2)
plugins/plugins.pro (+0/-1)
To merge this branch: bzr merge lp:~seb128/ubuntu-system-settings/dont-install-example
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+172103@code.launchpad.net

Commit message

don't install the example plugin, it's useful as source example,
not so much installed (especially since we have other working plugins)

Description of the change

don't install the example plugin, it's useful as source example,
not so much installed (especially since we have other working plugins)

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

You probably want to remove it from plugins/plugins.pro too

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

good point, I dropped it frop the .pro and re-enable the install rules in the example

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

You should probably make it conflict with the newer version so it gets remove.

review: Needs Fixing
82. By Sebastien Bacher

uncomment install rules, drop example from the project instead

Revision history for this message
Sebastien Bacher (seb128) wrote :

there you go

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Awesome!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-06-28 10:55:23 +0000
3+++ debian/control 2013-06-28 19:11:23 +0000
4@@ -27,19 +27,10 @@
5 libsystemsettings1 (= ${binary:Version}),
6 Recommends: ubuntu-mobile-icons,
7 ubuntu-system-settings-online-accounts,
8+Conflicts: ubuntu-system-settings-example
9 Description: System Settings application for Ubuntu Touch
10 System Settings for Ubuntu Touch.
11
12-Package: ubuntu-system-settings-example
13-Section: libs
14-Architecture: i386 amd64 armhf
15-Depends: ${misc:Depends},
16- ${shlibs:Depends},
17- ubuntu-system-settings (= ${binary:Version}),
18- libsystemsettings1 (= ${binary:Version}),
19-Description: System Settings Example plugin for Ubuntu Touch
20- Example plugin for Ubuntu System Settings
21-
22 Package: libsystemsettings1
23 Section: libs
24 Architecture: i386 amd64 armhf
25
26=== removed file 'debian/ubuntu-system-settings-example.install'
27--- debian/ubuntu-system-settings-example.install 2013-05-21 14:23:21 +0000
28+++ debian/ubuntu-system-settings-example.install 1970-01-01 00:00:00 +0000
29@@ -1,2 +0,0 @@
30-usr/lib/system-settings/libexample-plugin.so
31-usr/share/settings/system/example.settings
32
33=== modified file 'plugins/plugins.pro'
34--- plugins/plugins.pro 2013-06-28 15:30:03 +0000
35+++ plugins/plugins.pro 2013-06-28 19:11:23 +0000
36@@ -2,7 +2,6 @@
37 SUBDIRS = \
38 about \
39 background \
40- example \
41 flight-mode \
42 gps \
43 orientation-lock \

Subscribers

People subscribed via source and target branches