Merge lp:~seb128/ubuntu-system-settings/display-translated-names into lp:ubuntu-system-settings

Proposed by Sebastien Bacher
Status: Merged
Approved by: Ken VanDine
Approved revision: 946
Merged at revision: 957
Proposed branch: lp:~seb128/ubuntu-system-settings/display-translated-names
Merge into: lp:ubuntu-system-settings
Diff against target: 15 lines (+2/-1)
1 file modified
plugins/about/click.cpp (+2/-1)
To merge this branch: bzr merge lp:~seb128/ubuntu-system-settings/display-translated-names
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+232365@code.launchpad.net

Commit message

[storage] display translated names

Description of the change

[storage] display translated names

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

I tested on the device with a french locale and that works

Revision history for this message
Ken VanDine (ken-vandine) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/about/click.cpp'
2--- plugins/about/click.cpp 2014-07-01 12:20:08 +0000
3+++ plugins/about/click.cpp 2014-08-27 08:32:23 +0000
4@@ -81,9 +81,10 @@
5 goto out;
6 }
7
8- gchar * name = g_key_file_get_string (appinfo,
9+ gchar * name = g_key_file_get_locale_string (appinfo,
10 G_KEY_FILE_DESKTOP_GROUP,
11 G_KEY_FILE_DESKTOP_KEY_NAME,
12+ NULL,
13 NULL);
14
15 if (name) {

Subscribers

People subscribed via source and target branches