Merge lp:~seb128/ubuntu-system-settings/categories-no-effect into lp:ubuntu-system-settings

Proposed by Sebastien Bacher on 2015-02-02
Status: Merged
Approved by: Ken VanDine on 2015-02-11
Approved revision: 1281
Merged at revision: 1301
Proposed branch: lp:~seb128/ubuntu-system-settings/categories-no-effect
Merge into: lp:ubuntu-system-settings
Diff against target: 11 lines (+1/-0)
1 file modified
src/qml/CategoryGrid.qml (+1/-0)
To merge this branch: bzr merge lp:~seb128/ubuntu-system-settings/categories-no-effect
Reviewer Review Type Date Requested Status
Ken VanDine 2015-02-02 Approve on 2015-02-11
PS Jenkins bot continuous-integration Needs Fixing on 2015-02-02
Review via email: mp+248272@code.launchpad.net

Commit Message

categories: disable tap effect on the section headers

Description of the Change

categories: disable tap effect on the section headers

To post a comment you must log in.
Matthew Paul Thomas (mpt) wrote :

If -- as you suggested in bug 1417061 -- these items should be Header elements eventually, perhaps there should be an XXX comment here to change that once the new list items are introduced.

Ken VanDine (ken-vandine) wrote :

Thanks!

review: Approve
Sebastien Bacher (seb128) wrote :

@mpt, we use that hack on other list items already, there is no point documenting a particular change, review our use of that property is on our list for when we switch to the new toolkit api for listitems

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/CategoryGrid.qml'
2--- src/qml/CategoryGrid.qml 2014-10-24 20:14:27 +0000
3+++ src/qml/CategoryGrid.qml 2015-02-02 15:53:00 +0000
4@@ -17,6 +17,7 @@
5 ListItem.Standard {
6 id: header
7
8+ highlightWhenPressed: false
9 showDivider: false
10 text: categoryName
11 visible: repeater.count > 0

Subscribers

People subscribed via source and target branches