Merge lp:~seb128/ubuntu-system-settings/categories-no-effect into lp:ubuntu-system-settings
Proposed by
Sebastien Bacher
on 2015-02-02
| Status: | Merged |
|---|---|
| Approved by: | Ken VanDine on 2015-02-11 |
| Approved revision: | 1281 |
| Merged at revision: | 1301 |
| Proposed branch: | lp:~seb128/ubuntu-system-settings/categories-no-effect |
| Merge into: | lp:ubuntu-system-settings |
| Diff against target: |
11 lines (+1/-0) 1 file modified
src/qml/CategoryGrid.qml (+1/-0) |
| To merge this branch: | bzr merge lp:~seb128/ubuntu-system-settings/categories-no-effect |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ken VanDine | 2015-02-02 | Approve on 2015-02-11 | |
| PS Jenkins bot | continuous-integration | Needs Fixing on 2015-02-02 | |
|
Review via email:
|
|||
Commit Message
categories: disable tap effect on the section headers
Description of the Change
categories: disable tap effect on the section headers
To post a comment you must log in.
| Matthew Paul Thomas (mpt) wrote : | # |
If -- as you suggested in bug 1417061 -- these items should be Header elements eventually, perhaps there should be an XXX comment here to change that once the new list items are introduced.
| Sebastien Bacher (seb128) wrote : | # |
@mpt, we use that hack on other list items already, there is no point documenting a particular change, review our use of that property is on our list for when we switch to the new toolkit api for listitems


FAILED: Continuous integration, rev:1281 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- ci/1949/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 1104 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- vivid-i386- ci/219 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 982 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1102 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1102/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 17670
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- system- settings- ci/1949/ rebuild
http://