Merge lp:~seb128/ubuntu-system-settings/build-translations-template into lp:ubuntu-system-settings
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Iain Lane on 2014-11-12 | ||||
| Approved revision: | 1194 | ||||
| Merged at revision: | 1200 | ||||
| Proposed branch: | lp:~seb128/ubuntu-system-settings/build-translations-template | ||||
| Merge into: | lp:ubuntu-system-settings | ||||
| Diff against target: |
14 lines (+4/-0) 1 file modified
debian/rules (+4/-0) |
||||
| To merge this branch: | bzr merge lp:~seb128/ubuntu-system-settings/build-translations-template | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Iain Lane | 2014-11-05 | Approve on 2014-11-12 | |
| PS Jenkins bot | continuous-integration | Needs Fixing on 2014-11-10 | |
| David Planella (community) | Needs Information on 2014-11-05 | ||
|
Review via email:
|
|||
Commit Message
Update the translations template during the build
Description of the Change
Update the translations template during the build
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1180
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1180
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
- 1183. By Albert Astals Cid on 2014-11-05
-
Use AbstractButton for haptic feedback Fixes: 1389630
Approved by: Sebastien Bacher - 1184. By Mathieu Trudel-Lapierre on 2014-11-05
-
[bluetooth] make the bluetooth agent a notifyable property. Fixes: 1346483
Approved by: Iain Lane, PS Jenkins bot - 1185. By Ken VanDine on 2014-11-05
-
[orientation] String change to Rotation Lock
Fixes: 1388888
Approved by: Sebastien Bacher - 1186. By Sebastien Bacher on 2014-11-05
-
[notifications] update strings to match the design
Fixes: 1377286
Approved by: Ken VanDine - 1187. By PS Jenkins bot on 2014-11-05
-
Releasing 0.3+15.
04.20141105- 0ubuntu1 - 1188. By Nick Dedekind on 2014-11-05
-
Fixed switches & check-boxes going out of sync with backends. Fixes: 1336715
- 1189. By kevin gunn on 2014-11-05
-
fix white space issues
- 1190. By PS Jenkins bot on 2014-11-05
-
Releasing 0.3+15.
04.20141105. 1-0ubuntu1 - 1191. By PS Jenkins bot on 2014-11-08
-
Resync trunk
- 1192. By Launchpad Translations on behalf of system-settings-touch on 2014-11-08
-
Launchpad automatic translations update.
- 1193. By Launchpad Translations on behalf of system-settings-touch on 2014-11-09
-
Launchpad automatic translations update.
| Sebastien Bacher (seb128) wrote : | # |
The coded list of languages is a known issue from the cmake transition, I'm unsure how to fix it and I don't think the template update work should be blocked on that since that's not related to the changes made here
- 1194. By Sebastien Bacher on 2014-11-10
-
Update the translations template during the build
| Sebastien Bacher (seb128) wrote : | # |
(updated to not use dh_translations, that's not needed)
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1194
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
LGTM!
Somehow related: I've looked at po/CMakeLists.txt while doing the review to see what the 'pot' target does. One thing I've noticed is that there is a static list of languages to be built [1]. Could that not be determined dynamically, so that when there is a new language added, the CMakeLists.txt file does not need to be changed?
set(languages "ar;ast;
[1] http://