ubuntu-system-settings

Merge lp:~seb128/ubuntu-system-settings/battery-rendering-glitches into lp:ubuntu-system-settings

  1. battery-rendering-glitches
  2. Merge into trunk
Proposed by Sebastien Bacher on 2015-06-03
Status: Merged
Approved by: Ken VanDine on 2015-06-04
Approved revision: 1433
Merged at revision: 1434
Proposed branch: lp:~seb128/ubuntu-system-settings/battery-rendering-glitches
Merge into: lp:ubuntu-system-settings
Diff against target: 13 lines (+3/-0)
1 file modified
plugins/battery/PageComponent.qml (+3/-0)
To merge this branch: bzr merge lp:~seb128/ubuntu-system-settings/battery-rendering-glitches
Reviewer Review Type Date Requested Status
Ken VanDine 2015-06-03 Approve on 2015-06-04
PS Jenkins bot continuous-integration Approve on 2015-06-04
Review via email: mp+260991@code.launchpad.net

Commit Message

[battery] use round linejoin style to workaround rendering glitches

Description of the Change

[battery] use round linejoin style to workaround rendering glitches

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1433
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/2133/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3075
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/403
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2600
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3073
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3073/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20933

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/2133/rebuild

review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1433
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/2136/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3082
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/406
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2605
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3080
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3080/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20955

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/2136/rebuild

review: Approve (continuous-integration)
Ken VanDine (ken-vandine) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/battery/PageComponent.qml'
2--- plugins/battery/PageComponent.qml 2015-05-27 09:22:41 +0000
3+++ plugins/battery/PageComponent.qml 2015-06-03 17:53:14 +0000
4@@ -226,6 +226,9 @@
5
6 ctx.lineWidth = units.dp(2)
7
8+ /* Needed to avoid rendering glitches with point with the same x value
9+ (#1461624/QTBUG-34339) */
10+ ctx.lineJoin = "round"
11
12 ctx.translate(0, height)
13 // Invert the y axis so we draw from the bottom left

Subscribers

People subscribed via source and target branches