Merge lp:~seb128/ubuntu-archive-tools/indicate-oem-tag into lp:ubuntu-archive-tools

Proposed by Sebastien Bacher
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~seb128/ubuntu-archive-tools/indicate-oem-tag
Merge into: lp:ubuntu-archive-tools
Diff against target: 16 lines (+3/-2)
1 file modified
sru-report (+3/-2)
To merge this branch: bzr merge lp:~seb128/ubuntu-archive-tools/indicate-oem-tag
Reviewer Review Type Date Requested Status
Brian Murray Approve
Ubuntu Package Archive Administrators Pending
Review via email: mp+398337@code.launchpad.net

Commit message

indicate oem priority bugs in the sru report

Description of the change

Having the oem status reflected in the report is useful to make sure we give the proper priority to those items

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

This looks good from a code standpoint but I wonder who the target audience is here. Is the SRU team supposed to prioritize the release of oem SRUs or is it for people looking to verify SRUs?

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

The motivation for the change is to make easier for people doing the verifications to prioritize the most important items. I don't think the SRU team needs to have specific knowledge of teams priorities, also the report would be the wrong place because it's only built after the item is accepted.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sru-report'
2--- sru-report 2020-07-16 13:24:42 +0000
3+++ sru-report 2021-02-19 11:47:17 +0000
4@@ -457,9 +457,10 @@
5 cls += '"'
6
7 print('<a href="%s/bugs/%d" '
8- 'title="%s" %s>%d%s</a>' %
9+ 'title="%s" %s>%d%s%s</a>' %
10 (lp_url, b, hover_text.replace('"', ''), cls, b,
11- '(hw)' if 'hw-specific' in t else ''))
12+ '(hw)' if 'hw-specific' in t else '',
13+ '(oem)' if 'oem-priority' in t else ''))
14 if failed_and_removable:
15 proposed_failed.append((releases[release].name, pkg,
16 [str(b) for b in rpkg['bugs']]))

Subscribers

People subscribed via source and target branches