Merge lp:~seb128/ubuntu-archive-tools/confirmation-for-not-team-owned-promotion into lp:ubuntu-archive-tools

[Sebastien Bacher]

Request confirmation before promoting a package without known owner

The new MIR team process doesn't require the team to be subscribed upfront
so ensure we don't forget to check it's done before promoting.

[Didier Roche-Tolomelli (didrocks)]

Looks good overall, some fixes needed and nitpicks :) Thanks for tackling this!

review: Needs Fixing

[Iain Lane (laney)]

One review comment and one nitpick inline. Thanks for looking at this :>

review: Needs Fixing

[lp:~seb128/ubuntu-archive-tools/confirmation-for-not-team-owned-promotion]

1460. By Sebastien Bacher on 2021-03-09

Update to resolve some of the review comments
- replace the coded example by the real source
- check while iterating on the packages
- don't continue iterating after the first match
- limit the check to source promotions
- use if-not check pythonish syntax

1461. By Sebastien Bacher on 2021-03-09

use a safer default on only considering yes as a positive choice

1462. By Sebastien Bacher on 2021-03-09

reuse the launchpadlib distribution object

restrict the subscriber check to Ubuntu

[Sebastien Bacher (seb128)]

New commits pushed that should address the issue (and also restrict the check to the Ubuntu distribution, unsure if anyone ever change-override on other targets but since the MIR process is specific to Ubuntu I think it makes sense)

[Didier Roche-Tolomelli (didrocks)]

Thanks a lot! All my remarks are now addressed. Fine by me.

review: Approve

[Iain Lane (laney)]

👍

review: Approve

=== modified file 'change-override'
--- change-override	2020-03-02 11:24:44 +0000
+++ change-override	2021-03-09 09:43:26 +0000
@@ -112,8 +112,25 @@
 
         num_overridden = 0
         num_same = 0
+
+        # The MIR teams subscription is specific to Ubuntu
+        lpubuntu = None
+        if options.distribution.name == 'ubuntu':
+            lpubuntu = options.launchpad.distributions['ubuntu']
+
         for pubtype, publication in publications:
             if pubtype == "source":
+                if options.component == 'main' and lpubuntu:
+                    known_team_subscribed = False
+                    distribution_source_package = lpubuntu.getSourcePackage(name=publication.source_package_name)
+                    for subscription in distribution_source_package.getSubscriptions():
+                        subscriber = subscription.subscriber
+                        if subscriber.name in lputils.team_names:
+                            known_team_subscribed = True
+                            break
+                    if not known_team_subscribed:
+                        if YesNoQuestion().ask("No known owning team subscribed, do you really want to promote?", "no") != "yes":
+                            return
                 kwargs = source_kwargs
             else:
                 kwargs = binary_kwargs

=== modified file 'lputils.py'
--- lputils.py	2018-01-05 12:24:50 +0000
+++ lputils.py	2021-03-09 09:43:26 +0000
@@ -43,6 +43,27 @@
     '"ubuntu/partner" for a partner or copy archive.')
 
 
+team_names = [
+    'canonical-support',
+    'checkbox-bugs',
+    'desktop-packages',
+    'documentation-packages',
+    'foundations-bugs',
+    'kernel-packages',
+    'kubuntu-bugs',
+    'landscape',
+    'maas-maintainers',
+    'mir-team',
+    'oem-solutions-engineers',
+    'pkg-ime',
+    'snappy-dev',
+    'translators-packages',
+    'ubuntu-openstack',
+    'ubuntu-printing',
+    'ubuntu-security',
+    'ubuntu-server',
+    ]
+
 def setup_location(args, default_pocket="Release"):
     archive = None
     if getattr(args, "archive", False):

=== modified file 'package-subscribers'
--- package-subscribers	2021-01-21 17:06:42 +0000
+++ package-subscribers	2021-03-09 09:43:26 +0000
@@ -106,30 +106,9 @@
 
     lputils.setup_location(options)
 
-    team_names = [
-        'canonical-support',
-        'checkbox-bugs',
-        'desktop-packages',
-        'documentation-packages',
-        'foundations-bugs',
-        'kernel-packages',
-        'kubuntu-bugs',
-        'landscape',
-        'maas-maintainers',
-        'mir-team',
-        'oem-solutions-engineers',
-        'pkg-ime',
-        'snappy-dev',
-        'translators-packages',
-        'ubuntu-openstack',
-        'ubuntu-printing',
-        'ubuntu-security',
-        'ubuntu-server',
-        ]
-
     data = { "unsubscribed": [] }
     subscriptions = defaultdict(list)
-    for team_name in team_names:
+    for team_name in lputils.team_names:
         data[team_name] = []
         team = launchpad.people[team_name]
         team_subs = team.getBugSubscriberPackages()