Merge lp:~seb128/ubuntu-archive-tools/component-mismatches-mirtitles into lp:ubuntu-archive-tools

Proposed by Sebastien Bacher
Status: Merged
Merged at revision: 1428
Proposed branch: lp:~seb128/ubuntu-archive-tools/component-mismatches-mirtitles
Merge into: lp:ubuntu-archive-tools
Diff against target: 20 lines (+3/-6)
1 file modified
component-mismatches (+3/-6)
To merge this branch: bzr merge lp:~seb128/ubuntu-archive-tools/component-mismatches-mirtitles
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+395133@code.launchpad.net

Commit message

component-mismatches: always include the MIR titles

those are useful in the diff emails generated

Description of the change

The title does some useful context, especially for the diff emails generated.

Currently that's an example of summary we get mailed to the release mailing list when only the status is changing (https://lists.ubuntu.com/archives/ubuntu-release/2020-November/005129.html)

' MIR: #1889688 (Fix Released)'

which doesn't give enough information to tell you what request it is about, I personally often end up just copying the bug number to a webbrowser to go see if that's a package my team cares about. Having the title would probably be enough in most cases

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

I've updated only the txt output which is used for the diff generation, unsure if we want the same change in the html (it's not really required on the report since the package name is included there)

Revision history for this message
Iain Lane (laney) wrote :

Cheers. I just fixed a minor indentation problem, but it's merged now!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'component-mismatches'
2--- component-mismatches 2020-05-28 04:58:54 +0000
3+++ component-mismatches 2020-12-10 10:19:44 +0000
4@@ -74,13 +74,10 @@
5
6 def __str__(self):
7 if self.status not in ('Fix Committed', 'Fix Released') and self.assignee:
8- s = "MIR: #%d (%s for %s)" % (self.id, self.status,
9- self.assignee.display_name)
10+ s = "MIR: #%d (%s for %s) %s" % (self.id, self.status,
11+ self.assignee.display_name, self.title)
12 else:
13- s = "MIR: #%d (%s)" % (self.id, self.status)
14- # no need to repeat the standard title
15- if not self.title.startswith("[MIR]"):
16- s += " %s" % self.title
17+ s = "MIR: #%d (%s) %s" % (self.id, self.status, self.title)
18 return s
19
20 def html(self):

Subscribers

People subscribed via source and target branches