Merge lp:~seb128/ubuntu-archive-scripts/display-broken-binaries into lp:ubuntu-archive-scripts

Proposed by Sebastien Bacher on 2020-09-07
Status: Merged
Merged at revision: 293
Proposed branch: lp:~seb128/ubuntu-archive-scripts/display-broken-binaries
Merge into: lp:ubuntu-archive-scripts
Diff against target: 36 lines (+7/-1)
2 files modified
generate-team-p-m (+4/-1)
templates/team-report.html (+3/-0)
To merge this branch: bzr merge lp:~seb128/ubuntu-archive-scripts/display-broken-binaries
Reviewer Review Type Date Requested Status
Iain Lane 2020-09-07 Approve on 2020-09-18
Review via email: mp+390362@code.launchpad.net

Commit message

Displays the broken binaries information in the teams report

Description of the change

The current report has empty informations for packages making others uninstallable, with the change it does list the broken binaries information (on one line to keep it concise)

Example output https://people.canonical.com/~seb128/reportbinaries.html

(see gstreamer1.0 section)

To post a comment you must log in.
291. By Sebastien Bacher on 2020-09-07

Displays the broken binaries information in the teams report.

Iain Lane (laney) wrote :

Logic looks good I think, just asking for a couple of tweaks. Thanks!

review: Needs Fixing
Sebastien Bacher (seb128) wrote :

Thanks for the review, I merged trunk and pushed the suggested changes

292. By Sebastien Bacher on 2020-09-17

rebase on trunk

293. By Sebastien Bacher on 2020-09-17

simply the code a bit as suggested in the review

Iain Lane (laney) wrote :

Thanks Seb!

For the upstream question, I think maybe "release.debian.org" on the BTS.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'generate-team-p-m'
2--- generate-team-p-m 2020-08-13 09:36:50 +0000
3+++ generate-team-p-m 2020-09-17 19:51:08 +0000
4@@ -192,6 +192,7 @@
5 data = attr.ib(default=None) # data for package_in_proposed
6 unsatdepends = attr.ib(default=None) # [string]
7 unsatbuilddep = attr.ib(default=None) # [string]
8+ brokenbin = attr.ib(default=None) # [string]
9
10 _age = attr.ib(default=None)
11
12@@ -301,7 +302,9 @@
13 for p in packages:
14 unsatdbd[p].append(arch)
15 prob.unsatbuilddep = ['{}: {}'.format(p, ', '.join(sorted(arches))) for p, arches in sorted(unsatdbd.items())]
16-
17+ if 'implicit-deps' in item['policy_info']['implicit-deps']:
18+ if item['policy_info']['implicit-deps']['implicit-deps']['broken-binaries']:
19+ prob.brokenbin = item['policy_info']['implicit-deps']['implicit-deps']['broken-binaries']
20
21 package_to_problems = defaultdict(list)
22
23
24=== modified file 'templates/team-report.html'
25--- templates/team-report.html 2020-08-13 09:36:50 +0000
26+++ templates/team-report.html 2020-09-17 19:51:08 +0000
27@@ -113,6 +113,9 @@
28 </ul>
29 </li>
30 {% endif %}
31+ {% if prob.brokenbin %}
32+ <li>Binaries broken by the update: {{ prob.brokenbin | join(' ') }}</li>
33+ {% endif %}
34 {% if d["policy_info"]["block-bugs"] %}
35 <li>Blocked by bug:
36 {% for bug in d["policy_info"]["block-bugs"]|map("int")|sort|map("string") %}

Subscribers

People subscribed via source and target branches