Merge lp:~seb128/telephony-service/sounds-events-from-gsettings into lp:telephony-service
Proposed by
Sebastien Bacher
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Gustavo Pichorim Boiko | ||||
Approved revision: | 726 | ||||
Merged at revision: | 726 | ||||
Proposed branch: | lp:~seb128/telephony-service/sounds-events-from-gsettings | ||||
Merge into: | lp:telephony-service | ||||
Diff against target: |
139 lines (+20/-5) 6 files modified
CMakeLists.txt (+1/-0) approver/CMakeLists.txt (+2/-0) debian/control (+2/-0) libtelephonyservice/CMakeLists.txt (+2/-1) libtelephonyservice/ringtone.cpp (+11/-4) libtelephonyservice/ringtone.h (+2/-0) |
||||
To merge this branch: | bzr merge lp:~seb128/telephony-service/sounds-events-from-gsettings | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Gustavo Pichorim Boiko (community) | Approve | ||
Review via email: mp+178344@code.launchpad.net |
Commit message
read the ringtone and new message sounds from gsettings
Description of the change
read the ringtone and new message sounds from gsettings
To post a comment you must log in.
(that's a resubmit of https:/ /code.launchpad .net/~seb128/ phone-app/ ringtone- in-gsettings/ +merge/ 176968 which was against the phone-app and already got some reviews):
Notes copied:
Those changes are making the sounds to use for call/messages to be read from gsettings/ customizable, see https:/ /bugs.launchpad .net/phone- app/+bug/ 1202253 for some details
Note that I've not been able to actual test the runtime behaviour, because I don't have a working phone with a SIM ... is there any way to simulate phone calls on a desktop? The code build and is working fine in a standalone test application.