Merge lp:~seb128/software-center/invalid_db_open into lp:software-center

[Sebastien Bacher]

DB_NOMMAP needs to be set using set_flags, it's not valid in DBEnv.open

DB_NOMMAP needs to be set using set_flags, it's not valid in DBEnv.open

Note that the original commit was to fix performances problems. I suspect that the improvement had more to do with the fact that the db write was basically commented by the invalid use which makes the function hit an except before doing the work than by the flag use so the fix might create performances issues...

[Michael Vogt (mvo)]

Thanks

review: Approve

[dobey (dobey)]

review: Approve

=== modified file 'softwarecenter/backend/reviews/__init__.py'
--- softwarecenter/backend/reviews/__init__.py	2012-12-14 16:44:25 +0000
+++ softwarecenter/backend/reviews/__init__.py	2015-10-01 17:42:59 +0000
@@ -371,9 +371,9 @@
         env = bdb.DBEnv()
         if not os.path.exists(outdir):
             os.makedirs(outdir)
+        env.set_flags(bdb.DB_NOMMAP, True) # be gentle on e.g. nfs mounts
         env.open(outdir,
-                 bdb.DB_CREATE | bdb.DB_INIT_CDB | bdb.DB_INIT_MPOOL |
-                 bdb.DB_NOMMAP,  # be gentle on e.g. nfs mounts
+                 bdb.DB_CREATE | bdb.DB_INIT_CDB | bdb.DB_INIT_MPOOL,
                  0600)
         db = bdb.DB(env)
         db.open(outfile,