Merge lp:~seb128/software-center/gtkgrid-deprecated-nrow into lp:software-center

Proposed by Sebastien Bacher
Status: Merged
Approved by: dobey
Approved revision: 3325
Merged at revision: 3326
Proposed branch: lp:~seb128/software-center/gtkgrid-deprecated-nrow
Merge into: lp:software-center
Diff against target: 11 lines (+0/-1)
1 file modified
data/ui/gtk3/submit_review.ui (+0/-1)
To merge this branch: bzr merge lp:~seb128/software-center/gtkgrid-deprecated-nrow
Reviewer Review Type Date Requested Status
dobey Approve
Michael Vogt Approve
Review via email: mp+261855@code.launchpad.net

Commit message

don't use the gtkbox n_row property, it's deprecated in the newer gtk version,
which leads to runtime errors and a non working reviews dialog
(lp: #1445745)

Description of the change

don't use the gtkbox n_row property, it's deprecated in the newer gtk version,
which leads to runtime errors and a non working reviews dialog
(lp: #1445745)

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) :
review: Approve
Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/ui/gtk3/submit_review.ui'
2--- data/ui/gtk3/submit_review.ui 2011-10-02 02:45:50 +0000
3+++ data/ui/gtk3/submit_review.ui 2015-06-12 14:25:25 +0000
4@@ -406,7 +406,6 @@
5 <property name="can_focus">False</property>
6 <property name="row_spacing">12</property>
7 <property name="row_homogeneous">True</property>
8- <property name="n_rows">4</property>
9 <child>
10 <object class="GtkAlignment" id="alignment">
11 <property name="visible">True</property>