libappindicator

Merge lp:~seb128/libappindicator/clean-libindicate-buildeps into lp:libappindicator/13.04

  1. clean-libindicate-buildeps
  2. Merge into trunk.13.04
Proposed by Sebastien Bacher
Status: Merged
Approved by: Allan LeSage
Approved revision: 255
Merged at revision: 255
Proposed branch: lp:~seb128/libappindicator/clean-libindicate-buildeps
Merge into: lp:libappindicator/13.04
Diff against target: 27 lines (+7/-2)
2 files modified
debian/changelog (+7/-0)
debian/control (+0/-2)
To merge this branch: bzr merge lp:~seb128/libappindicator/clean-libindicate-buildeps
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Lars Karlitski (community) Approve
Review via email: mp+146137@code.launchpad.net

Commit message

stop build-depending on libindicate, it's deprecated and not used there

Description of the change

stop build-depending on libindicate, it's deprecated and not used there

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:249
http://jenkins.qa.ubuntu.com/job/libappindicator-ci/29/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libappindicator-ci/./build=pbuilder,distribution=coverity-raring,flavor=amd64/29/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libappindicator-ci/./build=pbuilder,distribution=raring,flavor=i386/29/console
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/libappindicator-ci/./build=pbuilder,distribution=raring,flavor=i386/29//artifact/results/coverity/NO_COVERITY_DEFECTS.txt

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/libappindicator-ci/29//rebuild/?

review: Needs Fixing (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

could somebody review this one? it's a trivial build-depends fix and it's pending for over a month...

Revision history for this message
Lars Karlitski (larsu) wrote :

Sorry Seb! I hadn't looked at the because Jenkins complained (which usually means I get pinged again when the MR gets updated).

Your change has nothing to do with those tests. Approving.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/libappindicator-autolanding/18/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libappindicator-autolanding/./build=pbuilder,distribution=coverity-raring,flavor=amd64/18/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/libappindicator-autolanding/./build=pbuilder,distribution=raring,flavor=i386/18/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

(of course changelog changed since and there is a conflict, fixed that, approving back)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/libappindicator-autolanding/19/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libappindicator-autolanding/./build=pbuilder,distribution=coverity-raring,flavor=amd64/19/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libappindicator-autolanding/./build=pbuilder,distribution=raring,flavor=i386/19/console
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/libappindicator-autolanding/./build=pbuilder,distribution=raring,flavor=i386/19//artifact/results/coverity/NO_COVERITY_DEFECTS.txt

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:255
http://jenkins.qa.ubuntu.com/job/libappindicator-ci/35/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libappindicator-ci/./build=pbuilder,distribution=coverity-raring,flavor=amd64/35/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libappindicator-ci/./build=pbuilder,distribution=raring,flavor=i386/35/console
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/libappindicator-ci/./build=pbuilder,distribution=coverity-raring,flavor=amd64/35//artifact/results/coverity/NO_COVERITY_DEFECTS.txt
    http://jenkins.qa.ubuntu.com/job/libappindicator-ci/./build=pbuilder,distribution=raring,flavor=i386/35//artifact/results/coverity/NO_COVERITY_DEFECTS.txt

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/libappindicator-ci/35//rebuild/?

review: Approve (continuous-integration)
Revision history for this message
Allan LeSage (allanlesage) wrote :

Approving to alert Jenkins to autoland. . . .

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-02-15 07:46:55 +0000
3+++ debian/changelog 2013-03-11 13:01:21 +0000
4@@ -1,3 +1,10 @@
5+libappindicator (12.10.1daily13.02.15-0ubuntu2) UNRELEASED; urgency=low
6+
7+ * stop build-depending on libindicate, it's deprecated and not used
8+ there
9+
10+ -- Sebastien Bacher <seb128@ubuntu.com> Mon, 11 Mar 2013 13:59:16 +0100
11+
12 libappindicator (12.10.1daily13.02.15-0ubuntu1) raring; urgency=low
13
14 [ Charles Kerr ]
15
16=== modified file 'debian/control'
17--- debian/control 2013-01-29 17:50:13 +0000
18+++ debian/control 2013-03-11 13:01:21 +0000
19@@ -24,8 +24,6 @@
20 gtk-sharp2-gapi,
21 libgtk2.0-cil-dev,
22 libdbus-glib-1-dev (>= 0.82),
23- libindicate-dev (>= 0.2.0),
24- libindicate-gtk-dev (>= 0.2.0),
25 libindicator-dev (>= 0.3.90),
26 libindicator3-dev (>= 0.3.90),
27 libdbusmenu-glib-dev (>= 0.5.90),

Subscribers

People subscribed via source and target branches