Launchpad itself

Merge ~seb128/launchpad:master into launchpad:master

  1. Git
  2. lp:~seb128/launchpad
  3. master
  4. Merge into master
Proposed by Sebastien Bacher
Status: Merged
Approved by: Colin Watson
Approved revision: 78db3df54e3e8ee0c17f12dee007fb1d5a9143dd
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~seb128/launchpad:master
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/lp/bugs/javascript/bug_tags_entry.js (+1/-1)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+380305@code.launchpad.net

Commit message

Default to a larger entry from bug tag editing

Not having to scroll is an usability improvement

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

The current default shows around 30 chars but with the Ubuntu workflow around rls bugs it's not uncommon to have bug lits list
'bionic rls-bb-incoming rls-ee-incoming rls-ff-incoming apport-bug'
editing those lists require scrolling which is inconvenient

Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/bugs/javascript/bug_tags_entry.js b/lib/lp/bugs/javascript/bug_tags_entry.js
2index da1ca45..dcb7880 100644
3--- a/lib/lp/bugs/javascript/bug_tags_entry.js
4+++ b/lib/lp/bugs/javascript/bug_tags_entry.js
5@@ -205,7 +205,7 @@ namespace.setup_tag_entry = function(available_official_tags) {
6 tag_list_span = bug_tags_div.one('#tag-list');
7
8 tag_input = Y.Node.create(
9- '<input type="text" id="tag-input" />');
10+ '<input type="text" style="width: 70%" id="tag-input" />');
11 tags_edit_spinner = Y.Node.create(
12 '<img src="/@@/spinner" id="tags-edit-spinner" class="hidden" />');
13 ok_button = Y.Node.create(

Subscribers

People subscribed via source and target branches

to status/vote changes: