language-selector

Merge lp:~seb128/language-selector/set-minimal-height into lp:ubuntu/trusty/language-selector

  1. set-minimal-height
  2. Merge into trusty
Proposed by Sebastien Bacher
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~seb128/language-selector/set-minimal-height
Merge into: lp:ubuntu/trusty/language-selector
Diff against target: 11 lines (+1/-0)
1 file modified
LanguageSelector/gtk/GtkLanguageSelector.py (+1/-0)
To merge this branch: bzr merge lp:~seb128/language-selector/set-minimal-height
Reviewer Review Type Date Requested Status
Gunnar Hjalmarsson Approve
Michael Vogt (community) Approve
Sebastien Bacher Pending
Review via email: mp+214959@code.launchpad.net

This proposal supersedes a proposal from 2014-04-09.

Commit message

set a minimal height for the details

Description of the change

set a minimal height for the details

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Looks good to me

review: Approve
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Nice fix. I struggled with it a year ago without success.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'LanguageSelector/gtk/GtkLanguageSelector.py'
2--- LanguageSelector/gtk/GtkLanguageSelector.py 2014-03-19 01:07:32 +0000
3+++ LanguageSelector/gtk/GtkLanguageSelector.py 2014-04-09 14:49:27 +0000
4@@ -674,6 +674,7 @@
5 expander = Gtk.Expander.new(_("Details"))
6 scroll = Gtk.ScrolledWindow()
7 scroll.set_policy(Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.AUTOMATIC)
8+ scroll.set_min_content_height(130)
9 textview = Gtk.TextView()
10 textview.set_cursor_visible(False)
11 textview.set_editable(False)

Subscribers

People subscribed via source and target branches