Merge lp:~seb128/indicator-bluetooth/browsing-not-working into lp:indicator-bluetooth

Proposed by Sebastien Bacher
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 96
Merged at revision: 96
Proposed branch: lp:~seb128/indicator-bluetooth/browsing-not-working
Merge into: lp:indicator-bluetooth
Diff against target: 18 lines (+5/-0)
1 file modified
src/desktop.vala (+5/-0)
To merge this branch: bzr merge lp:~seb128/indicator-bluetooth/browsing-not-working
Reviewer Review Type Date Requested Status
Robert Ancell Approve
PS Jenkins bot (community) continuous-integration Approve
Indicator Applet Developers Pending
Review via email: mp+294534@code.launchpad.net

Commit message

Remove the "browse" action since there is no working backend

Description of the change

Remove the "browse" action since there is no working backend

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Robert Ancell (robert-ancell) wrote :

I don't know the details of why / if the browse functionality should work but this and the bug report makes sense to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/desktop.vala'
2--- src/desktop.vala 2015-08-27 14:24:22 +0000
3+++ src/desktop.vala 2016-05-12 15:45:18 +0000
4@@ -136,9 +136,14 @@
5 if (device.is_connectable)
6 submenu.append_item (create_device_connection_menuitem (device));
7
8+ /* There is no working backend that can be used there, disable
9+ the action until that situation gets sorted out
10+ see http://launchpad.net/bugs/1562822
11+
12 if (device.supports_browsing)
13 submenu.append (_("Browse files…"),
14 @"indicator.desktop-browse-files::$(device.address)");
15+ */
16
17 if (device.supports_file_transfer)
18 submenu.append (_("Send files…"),

Subscribers

People subscribed via source and target branches