Merge lp:~seb128/gnome-control-center-unity/use-correct-color-raring into lp:gnome-control-center-unity/raring

Proposed by Sebastien Bacher
Status: Merged
Approved by: Michael Terry
Approved revision: 20
Merged at revision: 20
Proposed branch: lp:~seb128/gnome-control-center-unity/use-correct-color-raring
Merge into: lp:gnome-control-center-unity/raring
Diff against target: 22 lines (+3/-3)
1 file modified
appearance/cc-appearance-panel.c (+3/-3)
To merge this branch: bzr merge lp:~seb128/gnome-control-center-unity/use-correct-color-raring
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michael Terry Approve
Review via email: mp+169011@code.launchpad.net

Commit message

use the correct colors format for the background settings

libgnome-desktop is using GdkColor values but the code was writing GdkRGBA ones. The first one are deprecated but since that's what the other components want, that's what we should write.

Description of the change

use the correct colors format for the background settings

libgnome-desktop is using GdkColor values but the code was writing GdkRGBA ones. The first one are deprecated but since that's what the other components want, that's what we should write.

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Looks fine! Thanks, Seb.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'appearance/cc-appearance-panel.c'
2--- appearance/cc-appearance-panel.c 2013-04-08 09:16:43 +0000
3+++ appearance/cc-appearance-panel.c 2013-06-12 17:08:29 +0000
4@@ -874,15 +874,15 @@
5 CcAppearancePanel *panel)
6 {
7 CcAppearancePanelPrivate *priv = panel->priv;
8- GdkRGBA color;
9+ GdkColor color;
10 gchar *value;
11 gboolean is_pcolor = FALSE;
12
13- gtk_color_chooser_get_rgba (GTK_COLOR_CHOOSER (button), &color);
14+ gtk_color_button_get_color (button, &color);
15 if (WID ("style-pcolor") == GTK_WIDGET (button))
16 is_pcolor = TRUE;
17
18- value = gdk_rgba_to_string (&color);
19+ value = gdk_color_to_string (&color);
20
21 if (priv->current_background)
22 {

Subscribers

People subscribed via source and target branches

to all changes: