Merge lp:~seb128/gallery-app/validation-on-the-right into lp:gallery-app

Proposed by Sebastien Bacher
Status: Merged
Approved by: Arthur Mello
Approved revision: 1077
Merged at revision: 1089
Proposed branch: lp:~seb128/gallery-app/validation-on-the-right
Merge into: lp:gallery-app
Diff against target: 29 lines (+6/-6)
1 file modified
rc/qml/PickerScreen.qml (+6/-6)
To merge this branch: bzr merge lp:~seb128/gallery-app/validation-on-the-right
Reviewer Review Type Date Requested Status
Arthur Mello (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+235586@code.launchpad.net

Commit message

Have the affirmative action on the right

Description of the change

Have the affirmative action on the right

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Arthur Mello (artmello) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'rc/qml/PickerScreen.qml'
2--- rc/qml/PickerScreen.qml 2014-09-19 01:05:46 +0000
3+++ rc/qml/PickerScreen.qml 2014-09-23 09:30:08 +0000
4@@ -147,6 +147,12 @@
5
6 property list<Action> pickActions: [
7 Action {
8+ text: i18n.tr("Cancel")
9+ objectName: "cancelButton"
10+ iconName: "close"
11+ onTriggered: APP.contentPickingCanceled()
12+ },
13+ Action {
14 text: i18n.tr("Pick")
15 objectName: "pickButton"
16 enabled: allLoaded ? selectionLoader.item.selectedCount > 0 : false
17@@ -157,12 +163,6 @@
18 if (allLoaded)
19 APP.returnPickedContent(mediaLibraryLoader.item.selectedMedias);
20 }
21- },
22- Action {
23- text: i18n.tr("Cancel")
24- objectName: "cancelButton"
25- iconName: "close"
26- onTriggered: APP.contentPickingCanceled()
27 }
28 ]
29 }

Subscribers

People subscribed via source and target branches