Merge lp:~seb128/dialer-app/tweak-some-strings into lp:dialer-app

Proposed by Sebastien Bacher on 2015-07-17
Status: Merged
Approved by: Gustavo Pichorim Boiko on 2015-07-20
Approved revision: 436
Merged at revision: 440
Proposed branch: lp:~seb128/dialer-app/tweak-some-strings
Merge into: lp:dialer-app
Diff against target: 21 lines (+2/-4)
1 file modified
src/qml/DialerPage/DialerPage.qml (+2/-4)
To merge this branch: bzr merge lp:~seb128/dialer-app/tweak-some-strings
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) 2015-07-17 Approve on 2015-07-20
PS Jenkins bot continuous-integration Approve on 2015-07-17
Review via email: mp+265096@code.launchpad.net

Commit Message

Use "Phone" rather than "Keypad" for the default title, as recommended by
design.
Change "Flight Mode" to use proper casing

Description of the Change

Use "Phone" rather than "Keypad" for the default title, as recommended by
design.
Change "Flight Mode" to use proper casing

To post a comment you must log in.
436. By Sebastien Bacher on 2015-07-17

Use "Phone" rather than "Keypad" for the default title, as recommended by
design.
Change "Flight Mode" to use proper casing

Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/DialerPage/DialerPage.qml'
2--- src/qml/DialerPage/DialerPage.qml 2015-06-18 20:01:19 +0000
3+++ src/qml/DialerPage/DialerPage.qml 2015-07-17 09:01:55 +0000
4@@ -74,15 +74,13 @@
5 return " "
6 }
7 } else if (telepathyHelper.flightMode) {
8- return i18n.tr("Flight mode")
9+ return i18n.tr("Flight Mode")
10 } else if (mainView.account && mainView.account.simLocked) {
11 return i18n.tr("SIM Locked")
12 } else if (mainView.account && mainView.account.networkName != "") {
13 return mainView.account.networkName
14 } else if (multipleAccounts && !mainView.account) {
15- // TODO: check what should be displayed when there are multiple accounts
16- // but no default selected
17- return i18n.tr("Keypad")
18+ return i18n.tr("Phone")
19 }
20 return i18n.tr("No network")
21 }

Subscribers

People subscribed via source and target branches