Merge lp:~seb128/dialer-app/insert-char-cursor into lp:dialer-app

Proposed by Sebastien Bacher
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 409
Merged at revision: 430
Proposed branch: lp:~seb128/dialer-app/insert-char-cursor
Merge into: lp:dialer-app
Diff against target: 14 lines (+2/-2)
1 file modified
src/qml/DialerPage/DialerPage.qml (+2/-2)
To merge this branch: bzr merge lp:~seb128/dialer-app/insert-char-cursor
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
Michael Zanetti (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+260720@code.launchpad.net

Commit message

Insert '+' where the cursor is located

Description of the change

Insert '+' where the cursor is located

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

Tested it. Works fine now. Thanks. I'll leave top-approving to someone deeper involved in the project.

review: Approve
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/DialerPage/DialerPage.qml'
2--- src/qml/DialerPage/DialerPage.qml 2015-04-08 22:41:26 +0000
3+++ src/qml/DialerPage/DialerPage.qml 2015-06-01 13:48:25 +0000
4@@ -376,8 +376,8 @@
5 mainView.callVoicemail()
6 } else if (keycode == Qt.Key_0) {
7 // replace 0 by +
8- dialNumber = dialNumber.substring(0, dialNumber.length - 1)
9- dialNumber += "+"
10+ input.remove(input.cursorPosition - 1, input.cursorPosition)
11+ input.insert(input.cursorPosition, "+")
12 }
13 }
14 }

Subscribers

People subscribed via source and target branches