Merge lp:~seb128/compiz/update-apport-hook into lp:compiz/0.9.12

Proposed by Sebastien Bacher on 2015-11-27
Status: Merged
Approved by: Marco Trevisan (Treviño) on 2015-11-30
Approved revision: 3989
Merged at revision: 3992
Proposed branch: lp:~seb128/compiz/update-apport-hook
Merge into: lp:compiz/0.9.12
Diff against target: 22 lines (+4/-7)
1 file modified
debian/source_compiz.py (+4/-7)
To merge this branch: bzr merge lp:~seb128/compiz/update-apport-hook
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) 2015-11-27 Approve on 2015-11-30
PS Jenkins bot continuous-integration Needs Fixing on 2015-11-27
Review via email: mp+278835@code.launchpad.net

Commit Message

Update the apport hook, get the gsettings config not the gconf one

Description of the Change

Update the apport hook, get the gsettings config not the gconf one

Note that it depends on the fix from https://code.launchpad.net/~seb128/apport/relocatable-gsettings-schemas to work

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Marco Trevisan (Treviño) (3v1n0) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/source_compiz.py'
2--- debian/source_compiz.py 2012-07-02 15:26:04 +0000
3+++ debian/source_compiz.py 2015-11-27 15:30:39 +0000
4@@ -13,15 +13,12 @@
5 report.add_hooks_info(ui, srcpackage='xorg')
6 return
7
8-
9- # ok, add maximum interesting info without too much spam
10- report['CompizPlugins'] = command_output(['gconftool-2',
11- '--get', '/apps/compiz-1/general/screen0/options/active_plugins'])
12- # User configuration
13- report['GconfCompiz'] = command_output(['gconftool-2', '-R', '/apps/compiz-1'])
14+ # get the current profiles, gsettings returns the string quoted so strip those before using
15+ current_profile = command_output(['gsettings', 'get', 'org.compiz', 'current-profile']).strip("'")
16+ attach_gsettings_schema(report, 'org.compiz.core:/org/compiz/profiles/%s/plugins/core/' % current_profile)
17
18 unity_bug = False
19- if ui and "unity" in report['CompizPlugins'] and report['SourcePackage'] != "unity":
20+ if ui and "unity" in report['GsettingsChanges'] and report['SourcePackage'] != "unity":
21 if ui.yesno("Thanks for reporting this bug. It seems you have unity running. Is the issue you are reporting is related to unity itself rather than compiz?"):
22 unity_bug = True
23

Subscribers

People subscribed via source and target branches